https://bugzilla.redhat.com/show_bug.cgi?id=1645768
Bug ID: 1645768 Summary: Review Request: python-duecredit - Automated collection and reporting of citations for used software/methods/datasets Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sanjay.ankur@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: <spec info here> SRPM URL: <srpm info here>
Description: duecredit is being conceived to address the problem of inadequate citation of scientific software and methods, and limited visibility of donation requests for open-source software.
It provides a simple framework (at the moment for Python only) to embed publication or other references in the original code so they are automatically collected and reported to the user at the necessary level of reference detail, i.e. only references for actually used functionality will be presented back if software provides multiple citeable implementations.
Fedora Account System Username: ankursinha
F30 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30635402 F29 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30635483
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1276941 (fedora-neuro) Alias| |python-duecredit
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #1 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Forgot the spec/srpm links:
https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit.spec https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit-0.6.4-...
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- *** Bug 1645767 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl ---
%global _description %{expand:
Nice trick.
Please add a backslash at the end of this line, because otherwise there's an spurious empty line in each "Description" section.
%description doc %{_description}
Suggestion: maybe just say "documentation for %name".
rpmlint:
python3-duecredit.noarch: E: summary-too-long C Automated collection and reporting of citations for used software/methods/datasets
Yeah, please fix.
+ package name is OK + license is acceptable (BSD) + license is specified correctly + latest version + builds and installs OK + fedora-review finds no issues + BR/Requires/Provides look OK
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #4 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Thank you for the quick review, Zbigniew.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
%global _description %{expand:
Nice trick.
Stole if from another spec I saw ;)
Please add a backslash at the end of this line, because otherwise there's an spurious empty line in each "Description" section.
Done.
%description doc %{_description}
Suggestion: maybe just say "documentation for %name".
Done
rpmlint:
python3-duecredit.noarch: E: summary-too-long C Automated collection and reporting of citations for used software/methods/datasets
Yeah, please fix.
Done.
- package name is OK
- license is acceptable (BSD)
- license is specified correctly
- latest version
- builds and installs OK
- fedora-review finds no issues
- BR/Requires/Provides look OK
Package is APPROVED.
Thanks. Here is the updated spec/srpm:
https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit.spec https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit-0.6.4-...
Requesting scm now.
Cheers, Ankur
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-duecredit
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-duecredit-0.6.4-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c659fbecc6
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-duecredit-0.6.4-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a61ca72ac6
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-duecredit-0.6.4-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-af26dc28f1
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-duecredit-0.6.4-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c659fbecc6
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-duecredit-0.6.4-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-af26dc28f1
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-duecredit-0.6.4-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a61ca72ac6
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-11-14 21:12:00
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-duecredit-0.6.4-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-duecredit-0.6.4-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1645768
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-duecredit-0.6.4-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org