Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=515053

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?

--- Comment #1 from Jason Tibbitts tibbs@math.uh.edu 2009-09-09 20:20:14 EDT --- I was going to review this, but then I noticed that version 3 is out. Did you want to update this package?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=515053

--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2009-11-03 10:25:50 EDT --- Hmm, it's been longer than I thought since I looked at this.

Builds fine; rpmlint just says sugar-getiabooks.noarch: W: non-standard-group Sugar/Activities which is OK; I'm not sure why rpmlint still complains about this as we don't particularly care what goes in group anyway.

The NEWS file seems to be present twice in the final package.

Nothing seems to own /usr/share/sugar/activities. (Well, etoys owns it, but that's not in the dependency chain.) I think this is probably a bug in sugar, but absent that it's a bug in the guidelines and this package should own %{sugaractivitydir}. I've inquired on the fedora-packaging list.

* source files match upstream. sha256sum: fa25987241db043235b132c2c12aba56b1865947e35180990ea32c431c326fa4 GetIABooks-3.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK (though it's no longer required at all). * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: sugar-getiabooks = 3-1.fc12 = /usr/bin/env sugar (python is pulled in indirectly via sugar) ? nothing seems to own %{sugaractivitydir}. * doesn't own any directories it shouldn't. X NEWS seems to be duplicated. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=515053

--- Comment #5 from Fabian Affolter fabian@bernewireless.net 2009-11-13 18:31:24 EDT --- Thanks for the review Jason. The issue with the NEWS file is fixed now.

Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-getiabooks.spec SRPM URL: http://fab.fedorapeople.org/packages/XO/sugar-getiabooks-3-2.fc11.src.rpm

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=515053

Fabian Affolter fabian@bernewireless.net changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #7 from Fabian Affolter fabian@bernewireless.net 2009-11-19 12:30:27 EDT --- Sorry, it seams that I fixed the incoherent-version-in-changelog issue after the rpm build process and uploaded the stuff before make a new srpm. Thanks for the hint.

New Package CVS Request ======================= Package Name: sugar-getiabooks Short Description: Internet Archive Books receiver for Sugar Owners: fab Branches: F-11 F-12 InitialCC:

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=515053

--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-11-20 18:47:14 EDT --- sugar-getiabooks-3-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/sugar-getiabooks-3-2.fc12

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=515053

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA

--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-11-24 02:51:34 EDT --- sugar-getiabooks-3-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update sugar-getiabooks'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11963

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=515053

--- Comment #13 from Fedora Update System updates@fedoraproject.org 2009-12-07 02:34:00 EDT --- sugar-getiabooks-3-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=515053

--- Comment #14 from Fedora Update System updates@fedoraproject.org 2009-12-07 02:34:47 EDT --- sugar-getiabooks-3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.