https://bugzilla.redhat.com/show_bug.cgi?id=1175328
Rex Dieter <rdieter(a)math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #8 from Rex Dieter <rdieter(a)math.unl.edu> ---
naming: ok
sources: ok
77b4c7c1b8978955333782221e9fae97 powerdevil-5.1.1.tar.xz
license: ok
1. SHOULD use better project url, suggest:
URL:
https://projects.kde.org/projects/kde/workspace/powerdevil
2. SHOULD prefer/use
make install/fast DESTDIR=%{buildroot} ...
over
%make_install
3. SHOULD use %find_lang ... --with-kde ... to automatically pick up HTML
handbooks
4. SHOULD consider -libs subpkg, to be multilib-friendly (so not entire
powerdevil pkg gets multilib'd due to the included shlibs)
5. SHOULD drop unused (afaict)
BuildRequires: chrpath
Lots of should'd, but no must blockers, APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component