Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: smashteroid - Astrosmash Remake
Alias: smashteroid
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225130
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2007-01-31 03:50 EST -------
Jochen, Christopher, both thanks for your review.
(In reply to comment #3)
Here is my review:
==== MUST FIX ====
- Shouldnt this require hicolor-icon-theme?
Fixed
Fixed
- inform upstream of 64bit compiler warnings
I need to send all
my changes upstream, if I get around to it I'll fix all the
warnings (also the non 64 bit ones) before doing so.
==== QUESTIONS ====
- patch seems to include license-change.txt but its not included in %doc?
Yes, a
must-fix actually as Jochen has correctly identified.
- patch seems littered with ^Ms, not an issue, but difficult to read
Thats what you get when you take dos source code and port it to Linux with a
patch :)
(In reply to comment #7)
Is it easy to patch this so that high scores go in
/var/games/smashteroid?
Doable yes, easy unfortunately not. Not worth the work IMHO. A patch is ofcourse
welcome.
Here is a new version:
* Wed Jan 31 2007 Hans de Goede <j.w.r.degoede(a)hhs.nl> 1.11-2
- Not only create but actually package license-change.txt
- Add Requires: hicolor-icon-theme
- Use:
http://www.t3-i.com/smashteroid.htm as URL
Go get it here:
Spec URL:
http://people.atrpms.net/~hdegoede/smashteroid.spec
SRPM URL:
http://people.atrpms.net/~hdegoede/smashteroid-1.11-2.fc7.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.