https://bugzilla.redhat.com/show_bug.cgi?id=2315991
Bug ID: 2315991 Summary: Review Request: fex-emu-rootfs-fedora - Fedora-based RootFS for the FEX emulator Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/fex-emu-rootfs-fedora/fex-emu-rootf... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/650/124260650/fex-emu-rootfs-...
Description: This package provides a RootFS based on Fedora Linux to be used by the FEX emulator.
Fedora Account System Username: dcavalca
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Davide Cavalca davide@cavalca.name --- Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=124260564
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://pagure.io/fedora-ki | |wi-descriptions
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8098635 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Not a valid SPDX expression '(( GPL-1.0-or-later OR Artistic-1.0-Perl ) AND BSD-3-Clause) AND ((AFL-2.1 OR GPL-2.0-or-later) AND GPL-2.0-or-later) AND ((FTL OR GPL-2.0-or-later) AND BSD-3-Clause AND MIT AND MIT-Modern-Variant AND LicenseRef-Fedora-Public-Domain AND Zlib) AND ((GPL-1.0-or-later OR Artistic-1.0-Perl) AND Artistic-2.0) AND ((GPL-1.0-or-later OR Artistic-1.0-Perl) AND FSFAP) AND ((GPL-1.0-or-later OR Artistic-1.0-Perl) AND MPL-2.0) AND ((GPL-1.0-or-later OR Artistic-1.0-Perl) AND Martin-Birgmeier AND Spencer-86 AND MIT AND Unicode-3.0 AND LicenseRef-Fedora-Public-Domain) AND ((GPL-1.0-or-later OR Artistic-1.0-Perl) AND metamail) AND ((GPL-2.0-or-later OR LGPL-3.0-or-later) AND GPL-3.0-or-later) AND ((LGPL-3.0-or-later OR GPL-2.0-or-later OR (LGPL-3.0-or-later AND GPL-2.0-or-later)) AND GFDL-1.3-invariants-or-later) AND (Apache-2.0 AND GPL-3.0-or-later AND MIT) AND (Apache-2.0 AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND (Apache-2.0 OR LGPL-2.1-or-later)) AND (Apache-2.0 AND LicenseRef-scancode-google-patent-license-webm AND BSD-3-Clause AND FSFULLRWD) AND (Apache-2.0 WITH LLVM-exception AND BSD-3-Clause AND Zlib AND BSD-2-Clause) AND (Apache-2.0 WITH LLVM-exception OR BSD OR MIT) AND (Apache-2.0 WITH LLVM-exception OR NCSA) AND (BSD and MIT) AND (BSD-2-Clause AND BSD-3-Clause) AND (BSD-2-Clause AND FSFULLR AND GPL-2.0-or-later WITH Libtool-exception AND BSD-3-Clause AND FSFUL) AND (BSD-2-Clause AND HPND AND HPND-sell-variant AND ICU AND MIT AND MIT-open-group AND SGI-B-2.0 AND SMLNJ AND X11 AND X11-distribute-modifications-variant) AND (BSD-2-Clause AND ISC AND MIT AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (Unlicense OR MIT)) AND (BSD-2-Clause AND ISC) AND (BSD-2-Clause AND MIT) AND (BSD-2-Clause-Darwin AND BSD-2-Clause) AND (BSD-3-Clause AND BSD-2-Clause AND ISC) AND (BSD-3-Clause AND BSD-2-Clause) AND (BSD-3-Clause AND FSFULLR AND X11 AND GPL-2.0-or-later AND FSFAP AND FSFUL AND GPL-3.0-or-later) AND (BSD-3-Clause AND GPL-2.0-only) AND (BSD-3-Clause AND GPL-2.0-or-later AND GFDL-1.1-or-later) AND (BSD-3-Clause AND GPL-2.0-or-later) AND (BSD-3-Clause AND ISC AND LicenseRef-Fedora-Public-Domain) AND (BSD-3-Clause AND LGPL-2.1-or-later) AND (BSD-3-Clause AND MIT AND LicenseRef-Fedora-Public-Domain) AND (BSD-3-Clause AND MIT-open-group AND Zlib AND Apache-2.0) AND (BSD-3-Clause OR GPL-2.0-only) AND (BSD-3-Clause OR GPL-2.0-or-later) AND (BSD-3-clause AND TU-Berlin-1.0) AND (Brian-Gladman-2-Clause AND BSD-2-Clause AND (BSD-2-Clause OR GPL-2.0-or-later) AND BSD-2-Clause-first-lines AND BSD-3-Clause AND BSD-4-Clause AND CMU-Mach-nodoc AND FSFULLRWD AND HPND AND HPND-export2-US AND HPND-export-US AND HPND-export-US-acknowledgement AND HPND-export-US-modify AND ISC AND MIT AND MIT-CMU AND OLDAP-2.8 AND OpenVision) AND (CC0-1.0 AND CC-BY-1.0 AND CC-BY-SA-1.0 AND GFDL-1.1-or-later) AND (CC0-1.0 OR Apache-1.0 OR Apache-2.0) AND (GPL+ or Artistic) AND (GPL-1.0-or-later AND GPL-2.0-or-later AND GPL-3.0-or-later WITH Autoconf-exception-generic AND Boehm-GC) AND (GPL-1.0-or-later OR Artistic-1.0-Perl) AND (GPL-2.0-only AND GPL-2.0-or-later AND BSD-2-Clause AND BSD-3-Clause AND BSD-4-Clause-UC AND LicenseRef-Fedora-Public-Domain) AND (GPL-2.0-only AND GPL-2.0-or-later AND LGPL-2.0-only AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND LGPL-3.0-or-later AND BSD-3-Clause AND IJG-short AND (MIT OR Unlicense)) AND (GPL-2.0-only AND LGPL-2.1-or-later) AND (GPL-2.0-only OR BSD-2-Clause AND BSD-3-Clause) AND (GPL-2.0-or-later AND BSD-2-Clause) AND (GPL-2.0-or-later AND GPL-3.0-or-later AND FSFUL AND FSFULLRWD AND LGPL-2.1-only AND LGPL-2.1-or-later AND X11) AND (GPL-2.0-or-later AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND BSD-2-Clause) AND (GPL-2.0-or-later AND LGPL-2.1-only AND MIT AND BSD-4-Clause-UC AND MS-PL AND MPL-1.1) AND (GPL-2.0-or-later AND LGPL-2.1-or-later) AND (GPL-2.0-or-later AND LicenseRef-Fedora-Public-Domain) AND (GPL-2.0-or-later AND MIT AND BSD-2-Clause) AND (GPL-2.0-or-later AND MIT) AND (GPL-2.0-or-later OR Artistic-1.0-Perl) AND (GPL-2.0-or-later OR LGPL-2.1-or-later) AND (GPL-2.0-or-later OR LGPL-3.0-or-later) AND (GPL-2.0-or-later WITH Autoconf-exception-generic) AND (GPL-2.0-or-later WITH SANE-exception AND GPL-2.0-or-later AND GPL-2.0-only AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND LicenseRef-Fedora-Public-Domain AND IJG AND MIT) AND (GPL-3.0-or-later AND (Apache-2.0 OR MIT) AND MIT AND (MIT OR Apache-2.0) AND (Unlicense OR MIT)) AND (GPL-3.0-or-later AND (GPL-3.0-or-later WITH Bison-exception-2.2) AND (LGPL-2.0-or-later WITH GCC-exception-2.0) AND BSD-3-Clause AND GFDL-1.3-or-later AND GPL-2.0-or-later LGPL-2.1-or-later AND LGPL-2.0-or-later) AND (GPL-3.0-or-later AND (GPL-3.0-or-later WITH GCC-exception-3.1) AND GPL-2.0-or-later AND (GPL-2.0-or-later WITH GCC-exception-2.0) AND LGPL-2.0-or-later) AND (GPL-3.0-or-later AND GFDL-1.3-no-invariants-or-later AND LGPL-2.1-or-later AND LGPL-3.0-or-later) AND (GPL-3.0-or-later AND GFDL-1.3-only) AND (GPL-3.0-or-later AND GFDL-1.3-or-later AND BSD-4-Clause-UC AND MIT AND X11 AND LicenseRef-Fedora-Public-Domain) AND (GPL-3.0-or-later AND GPL-2.0-or-later AND GFDL-1.3-no-invariants-or-later) AND (GPL-3.0-or-later AND GPL-2.0-or-later AND LGPL-2.1-or-later AND BSD-3-Clause) AND (GPL-3.0-or-later AND LGPL-2.1-or-later) AND (GPL-3.0-or-later AND LGPL-3.0-or-later AND (GPL-3.0-or-later WITH GCC-exception-3.1) AND (GPL-3.0-or-later WITH Texinfo-exception) AND (LGPL-2.1-or-later WITH GCC-exception-2.0) AND (GPL-2.0-or-later WITH GCC-exception-2.0) AND (GPL-2.0-or-later WITH GNU-compiler-exception) AND BSL-1.0 AND GFDL-1.3-or-later AND Linux-man-pages-copyleft-2-para AND SunPro AND BSD-1-Clause AND BSD-2-Clause AND BSD-2-Clause-Views AND BSD-3-Clause AND BSD-4-Clause AND BSD-Source-Code AND Zlib AND MIT AND Apache-2.0 AND (Apache-2.0 WITH LLVM-Exception) AND ZPL-2.1 AND ISC AND LicenseRef-Fedora-Public-Domain AND HP-1986 AND curl AND Martin-Birgmeier AND HPND-Markus-Kuhn AND dtoa AND SMLNJ AND AMD-newlib AND OAR AND HPND-merchantability-variant AND HPND-Intel) AND (GPL-3.0-or-later AND LGPL-3.0-or-later AND LGPL-2.1-or-later AND GPL-2.0-or-later AND LGPL-2.0-or-later AND GFDL-1.3-no-invariants-or-later) AND (GPL-3.0-or-later AND LGPL-3.0-or-later) AND (GPL-3.0-or-later AND MIT) AND (HPND AND HPND-sell-variant AND X11 AND X11-distribute-modifications-variant AND MIT AND MIT-open-group AND xkeyboard-config-Zinoviev) AND (HPND AND LicenseRef-Fedora-Public-Domain AND Unicode-DFS-2016) AND (HPND AND MIT) AND (ISC AND BSD-2-Clause AND BSD-3-Clause AND BSD-4-Clause-UC) AND (ISC AND BSD-4-Clause AND BSD-2-Clause AND pkgconf AND MIT) AND (LGPL-2.0-or-later AND Apache-2.0 AND BSL-1.0 AND MIT AND Unicode-DFS-2016 AND (Apache-2.0 OR MIT) AND (MIT OR Apache-2.0 OR Zlib) AND (Unlicense OR MIT)) AND (LGPL-2.0-or-later AND BSD-3-Clause) AND (LGPL-2.0-or-later AND LGPL-2.1-or-later) AND (LGPL-2.1-only OR MPL-1.1) AND (LGPL-2.1-or-later AND BSD-3-Clause AND BSD-2-Clause AND BSD-2-Clause-FreeBSD AND 0BSD AND CC0-1.0 AND LicenseRef-Fedora-Public-Domain) AND (LGPL-2.1-or-later AND GPL-2.0-or-later AND BSD-3-Clause) AND (LGPL-2.1-or-later AND GPL-2.0-or-later AND IJG-short AND BSD-2-Clause) AND (LGPL-2.1-or-later AND LGPL-2.0-or-later AND BSD-2-Clause-Views AND MIT) AND (LGPL-2.1-or-later AND LGPL-2.1-only AND BSD-2-Clause) AND (LGPL-2.1-or-later AND MIT AND GPL-2.0-or-later) AND (LGPL-2.1-or-later AND MIT) AND (LGPL-2.1-or-later AND SunPro AND LGPL-2.1-or-later WITH GCC-exception-2.0 AND BSD-3-Clause AND GPL-2.0-or-later AND LGPL-2.1-or-later WITH GNU-compiler-exception AND GPL-2.0-only AND ISC AND LicenseRef-Fedora-Public-Domain AND HPND AND CMU-Mach AND LGPL-2.0-or-later AND Unicode-3.0 AND GFDL-1.1-or-later AND GPL-1.0-or-later AND FSFUL AND MIT AND Inner-Net-2.0 AND X11 AND GPL-2.0-or-later WITH GCC-exception-2.0 AND GFDL-1.3-only AND GFDL-1.1-only) AND (LGPL-2.1-or-later AND Unicode-DFS-2016) AND (LGPL-2.1-or-later OR MPL-2.0 OR GPL-2.0-or-later) AND (LGPL-3.0-only OR CC-BY-SA-3.0) AND (LGPL-3.0-or-later OR GPL-2.0-or-later) AND (LGPLv2 and MPLv1.1) AND (LicenseRef-BSD-3-Clause-Clear-WITH-AdditionRef-AOMPL-1.0 AND MIT AND ISC AND LicenseRef-Fedora-Public-Domain) AND (LicenseRef-Callaway-LGPLv2+ AND LicenseRef-Callaway-LGPLv2) AND (LicenseRef-Fedora-Public-Domain AND (GPL-2.0-only WITH ClassPath-exception-2.0)) AND (LicenseRef-Fedora-Public-Domain AND ZPL-2.1) AND (MIT AND BSD-3-Clause AND SGI-B-2.0) AND (MIT AND CC-PDDC AND (GPL-3.0-or-later WITH Texinfo-exception)) AND (MIT AND GPL-2.0-or-later) AND (MIT AND GPL-3.0-or-later) AND (MIT AND HPND-sell-variant AND ICU) AND (MIT AND HPND-sell-variant AND SMLNJ AND MIT-open-group AND X11) AND (MIT AND HPND-sell-variant) AND (MIT AND ISC-Veillard AND W3C) AND (MIT AND LicenseRef-Fedora-Public-Domain) AND (MIT AND MIT-open-group AND X11) AND (MIT AND MIT-open-group) AND (MIT AND PSF-2.0 AND GPL-2.0-or-later) AND (MIT AND Python-2.0.1 AND Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause AND ISC AND MPL-2.0 AND (Apache-2.0 OR BSD-2-Clause)) AND (MIT AND X11 AND HPND AND CC-BY-4.0) AND (MIT AND X11 AND MIT-CMU) AND (MIT AND X11) AND (MIT AND X11-distribute-modifications-variant) AND (MIT-feh AND MIT-Modern-Variant AND BSD-1-Clause AND BSD-3-Clause AND GPL-3.0-or-later WITH Autoconf-exception-macro) AND (MIT-open-group AND HPND-sell-variant AND X11 AND HPND-doc AND HPND-doc-sell) AND (MIT-open-group AND SMLNJ AND MIT) AND (MIT-open-group AND SMLNJ AND X11 AND ISC) AND (MIT-open-group AND X11 AND HPND AND HPND-sell-variant AND SMLNJ AND MIT AND ISC AND HPND-doc AND HPND-doc-sell) AND (MIT-open-group AND X11 AND HPND AND HPND-sell-variant AND SMLNJ AND NTP) AND (MPLv1.1 or GPLv2+ or LGPLv2+) AND (Public Domain) AND (Python-2.0.1 AND CC0-1.0 AND MIT) AND (SISSL AND BSD-3-Clause) AND (SMLNJ AND HPND-sell-variant) AND (Unicode-DFS-2016 AND BSD-2-Clause AND BSD-3-Clause AND LicenseRef-Fedora-Public-Domain) AND (X11-distribute-modifications-variant AND HPND-sell-variant) AND (Zlib AND BSD-3-Clause AND MIT AND IJG) AND (Zlib AND MIT AND Apache-2.0 AND (Apache-2.0 OR MIT)) AND (zlib and (Public Domain or MIT-0) and MIT) AND 0BSD AND Apache-2.0 AND Artistic-2.0 AND BSD-2-Clause AND BSD-2-Clause-Patent AND BSD-3-Clause AND BSD-4-Clause AND BSD-Attribution-HPND-disclaimer AND CC0 AND CC0-1.0 AND FDK-AAC AND FSFAP AND GD AND GPL-1.0-or-later AND GPL-2.0-only AND GPL-2.0-or-later AND GPL-3.0-only AND GPL-3.0-or-later AND HPND-sell-variant AND ISC AND Info-ZIP AND LGPL-2.0-or-later AND LGPL-2.1-only AND LGPL-2.1-or-later AND LGPL-3.0-or-later AND LGPLv2 AND LGPLv2+ AND LicenseRef-Fedora-Public-Domain AND LicenseRef-Liberation AND MIT AND MIT-Modern-Variant AND MIT-open-group AND MPL-2.0 AND NCSA AND OFL AND OFL-1.1 AND OFL-1.1-RFN AND OLDAP-2.8 AND Python-2.0.1 AND TTWL AND X11 AND X11-distribute-modifications-variant AND Zlib AND blessing AND curl AND libtiff AND pubkey AND tu-berlin-2.0 AND zlib'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
--- Comment #4 from Davide Cavalca davide@cavalca.name ---
Not a valid SPDX expression
This is generated programmatically from the image manifest. It's likely invalid because some packages have themselves invalid tags.
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
--- Comment #5 from Davide Cavalca davide@cavalca.name --- Filed https://src.fedoraproject.org/rpms/mingw-binutils/pull-request/4 to fix the invalid SPDX expression
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- So this package is kind of special, so I'm going to treat this a bit differently...
Review notes:
* Package "builds" and installs (it trivially puts files in a specific location) * Licensing is "correct" (as it is an aggregate of the license tags of all included packages) * No serious rpmlint errors
I wonder if we should treat this the same way we treat the license tag for container images and just put the MIT license here (since that's the license of the Fedora collection)? It seems more reasonable to do that rather than have this enormous blob of licenses...
I guess for now we can leave it this way and then ask afterward if we can simplify this, because I'd rather not have this crazy license tag...
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- Nit:
Version: 0
This should probably reflect the Fedora version embedded (in this case, 42).
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/fex-emu-rootfs-fedora
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-816c292d6f (fex-emu-rootfs-fedora-42-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-816c292d6f
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-10-03 22:02:43
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-816c292d6f (fex-emu-rootfs-fedora-42-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-9015122f44 (fex-emu-rootfs-fedora-42-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9015122f44
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-c6be6e975d (fex-emu-rootfs-fedora-42-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c6be6e975d
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-c6be6e975d (fex-emu-rootfs-fedora-42-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-9015122f44 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9015122f44 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9015122f44
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2315991
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-9015122f44 (fex-emu-rootfs-fedora-42-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org