[Bug 2126927] New: Review Request: gap-pkg-standardff - Standardized generation of finite fields and cyclic subgroups
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
Bug ID: 2126927 Summary: Review Request: gap-pkg-standardff - Standardized generation of finite fields and cyclic subgroups Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loganjerry@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jjames.fedorapeople.org/gap-pkg-standardff/gap-pkg-standardff.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-standardff/gap-pkg-standardff-0.9.4-... Fedora Account System Username: jjames Description: The StandardFF package contains an implementation of *standard* generators of finite fields and of cyclic subgroups in the multiplicative groups of finite fields, as described in https://arxiv.org/abs/2107.02257.
This package is needed as part of an upgrade of the gap package to version 4.12.0. See here for a COPR containing the relevant builds: https://copr.fedorainfracloud.org/coprs/jjames/GAP4.12/
A build of this package can be found here: https://copr.fedorainfracloud.org/coprs/jjames/GAP4.12/build/4836940/
Mock builds against this repo can be done with this config:
include('/etc/mock/fedora-rawhide-x86_64.cfg')
config_opts['root'] = 'fedora-rawhide-x86_64'
config_opts[f'{config_opts.package_manager}.conf'] += """
[gap] name=Copr repo for gap owned by jjames baseurl=https://copr-be.cloud.fedoraproject.org/results/jjames/GAP4.12/fedora-rawhid... type=rpm-md skip_if_unavailable=False gpgcheck=1 gpgkey=https://copr-be.cloud.fedoraproject.org/results/jjames/GAP4.12/pubkey.gpg repo_gpgcheck=0 enabled=1 enabled_metadata=1 cost=10 """
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value Flags| |fedora-review? CC| |benson_muite@emailplus.org
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal)
--- Comment #1 from Benson Muite benson_muite@emailplus.org --- Related issue for Knuth license https://gitlab.com/fedora/legal/fedora-license-data/-/issues/18
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
--- Comment #2 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 49 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/gap-pkg-standardff/2126927-gap-pkg- standardff/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4
gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/gap-pkg-standardff-0.9.4-1.fc38.x86_64 gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/factors-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findirr-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGF2-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGFp-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFp-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFq-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/gap-pkg-standardff-0.9.4-1.fc38.x86_64 gap-pkg-standardff-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-standardff-doc.noarch: W: no-documentation gap-pkg-standardff-debuginfo.x86_64: W: no-documentation gap-pkg-standardff-debugsource.x86_64: W: no-documentation gap-pkg-standardff-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/gap-pkg-standardff-0.9.4-1.fc38.x86_64 gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/factors-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/factors-0.9.4-1.fc38.x86_64.debug'
gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findirr-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findirr-0.9.4-1.fc38.x86_64.debug'
gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGF2-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGF2-0.9.4-1.fc38.x86_64.debug'
gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGFp-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGFp-0.9.4-1.fc38.x86_64.debug'
gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFp-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFp-0.9.4-1.fc38.x86_64.debug'
gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFq-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFq-0.9.4-1.fc38.x86_64.debug'
gap-pkg-standardff-doc.noarch: W: invalid-license GPL-3.0-or-later gap-pkg-standardff-doc.noarch: W: invalid-license OFL-1.1-RFN gap-pkg-standardff-doc.noarch: W: invalid-license AGPL-3.0-only gap-pkg-standardff-debuginfo.x86_64: W: invalid-license GPL-3.0-or-later gap-pkg-standardff.x86_64: W: invalid-license GPL-3.0-or-later gap-pkg-standardff-debugsource.x86_64: W: invalid-license GPL-3.0-or-later gap-pkg-standardff-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz gap-pkg-standardff-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/toggless.js ../../GAPDoc/styles/toggless.js gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/05/771a946ee5c06b3db7dce65d7d269cecf58048 ../../../.build-id/05/771a946ee5c06b3db7dce65d7d269cecf58048 gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/12/09a28f2e5ebbc5be3517464d406bf19f07bca1 ../../../.build-id/12/09a28f2e5ebbc5be3517464d406bf19f07bca1 gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/1b/59a58078087f0d806d7647ba64f12849698a5a ../../../.build-id/1b/59a58078087f0d806d7647ba64f12849698a5a gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/3c/8f66ae70a6ac5e442ed460709a44285c13cdb7 ../../../.build-id/3c/8f66ae70a6ac5e442ed460709a44285c13cdb7 gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/e5/0321abc95de97db9800e72513abeb087bab493 ../../../.build-id/e5/0321abc95de97db9800e72513abeb087bab493 gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/f4/0f8ce3b08e6961f1e8d0b4c1cf3eaf835f89e6 ../../../.build-id/f4/0f8ce3b08e6961f1e8d0b4c1cf3eaf835f89e6 4 packages and 0 specfiles checked; 8 errors, 35 warnings, 8 badness; has taken 6.0 s
Source checksums ---------------- https://github.com/frankluebeck/StandardFF/archive/v0.9.4/StandardFF-0.9.4.t... : CHECKSUM(SHA256) this package : a4e0422d0a74ebd3bd426ffc50f3e27048f8862708469540c0ef85d9cb6292c6 CHECKSUM(SHA256) upstream package : a4e0422d0a74ebd3bd426ffc50f3e27048f8862708469540c0ef85d9cb6292c6
Requires -------- gap-pkg-standardff (rpmlib, GLIBC filtered): gap-core libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libntl.so.44()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH)
gap-pkg-standardff-doc (rpmlib, GLIBC filtered): gap-online-help gap-pkg-standardff
gap-pkg-standardff-debuginfo (rpmlib, GLIBC filtered):
gap-pkg-standardff-debugsource (rpmlib, GLIBC filtered):
Provides -------- gap-pkg-standardff: gap-pkg-standardff gap-pkg-standardff(x86-64)
gap-pkg-standardff-doc: gap-pkg-standardff-doc
gap-pkg-standardff-debuginfo: debuginfo(build-id) gap-pkg-standardff-debuginfo gap-pkg-standardff-debuginfo(x86-64)
gap-pkg-standardff-debugsource: gap-pkg-standardff-debugsource gap-pkg-standardff-debugsource(x86-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2126927 -m gap Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: PHP, Python, Perl, C/C++, R, Haskell, SugarActivity, Ocaml, fonts, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
$ rpmlint gap-pkg-standardff-0.9.4-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gap-pkg-standardff.src: W: invalid-license GPL-3.0-or-later 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 2.6 s
$ rpmlint gap-pkg-standardff-0.9.4-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gap-pkg-standardff.src: W: invalid-license GPL-3.0-or-later 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s
$ rpmlint gap-pkg-standardff-doc-0.9.4-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gap-pkg-standardff-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-standardff-doc.noarch: W: no-documentation gap-pkg-standardff-doc.noarch: W: invalid-license GPL-3.0-or-later gap-pkg-standardff-doc.noarch: W: invalid-license OFL-1.1-RFN gap-pkg-standardff-doc.noarch: W: invalid-license AGPL-3.0-only gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/toggless.js ../../GAPDoc/styles/toggless.js 1 packages and 0 specfiles checked; 0 errors, 15 warnings, 0 badness; has taken 0.8 s
Comments: a) Waiting for review of Knuth license, though it will likely affect many other packages. b) Might add more information on excluded architectures since %{gap_arches} macro is new c) Assume would need other related packages to be included in Fedora at the same time
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
--- Comment #3 from Jerry James loganjerry@gmail.com --- Thank you for the review, Benson.
(In reply to Benson Muite from comment #2)
[!]: Package is not known to require an ExcludeArch tag.
Only 32-bit x86 is excluded, and this is not only allowed, but encouraged: https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
Comments: a) Waiting for review of Knuth license, though it will likely affect many other packages.
Right, thanks for prodding Richard about that.
b) Might add more information on excluded architectures since %{gap_arches} macro is new
I'm preparing an update to the GAP packaging guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/GAP/) that will cover this topic. I meant to have that ready already, but what can I say? It isn't. I'll try to finish that up tomorrow and get it submitted.
c) Assume would need other related packages to be included in Fedora at the same time
No, this is the only package to be added. The rest of the GAP stack is getting updates, some quite significant, but only the 1 new package.
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
--- Comment #4 from Benson Muite benson_muite@emailplus.org --- Main thing here seems to be the fonts. There seems to be some progress on this: https://gitlab.com/fedora/legal/fedora-license-data/-/issues/18
It seems possible not to embed fonts, though only system fonts will be reliably replaced: https://tex.stackexchange.com/questions/662433/production-of-pdf-without-emb...
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
Richard Fontana rfontana@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rfontana@redhat.com Blocks|182235 (FE-Legal) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
--- Comment #5 from Richard Fontana rfontana@redhat.com --- I lifted FE-Legal here because I think the issues that were flagged only involve (at this point) questions about representing allowed licenses in RPM metadata.
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Benson Muite benson_muite@emailplus.org --- Thanks. Correct functionality assumed based on tests. Approved. As per: https://gitlab.com/fedora/legal/fedora-license-data/-/issues/18 https://github.com/spdx/license-list-XML/issues/1657 Can you add Knuth-CTAN license, and update the license breakdown indicating the license of the fonts embedded in the PDF when importing.
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
--- Comment #7 from Jerry James loganjerry@gmail.com --- Thank you, Benson! I will absolutely do that. I appreciate you sticking with this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
--- Comment #8 from Kevin Fenzi kevin@scrye.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-standardff
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-95a13c4ebc has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-95a13c4ebc
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-95a13c4ebc has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-95a13c4ebc *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-95a13c4ebc
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2022-12-04 00:28:35
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-95a13c4ebc has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com