Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=876405
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #5 from Petr Pisar <ppisar(a)redhat.com> ---
Spec file changes:
--- perl-Module-Build-WithXSpp.spec.old 2013-01-02 10:23:19.413000000 +0100
+++ perl-Module-Build-WithXSpp.spec 2013-01-02 10:16:35.566000000 +0100
@@ -1,36 +1,29 @@
Name: perl-Module-Build-WithXSpp
Version: 0.12
-Release: 1%{?dist}
+Release: 3%{?dist}
Summary: XS++ enhanced flavor of Module::Build
License: GPL+ or Artistic
Group: Development/Libraries
URL:
http://search.cpan.org/dist/Module-Build-WithXSpp/
Source0:
http://www.cpan.org/authors/id/S/SM/SMUELLER/Module-Build-WithXSpp-%{vers...
BuildArch: noarch
-BuildRequires: perl(Digest::MD5)
-BuildRequires: perl(ExtUtils::CBuilder)
BuildRequires: perl(ExtUtils::CppGuess) >= 0.04
-BuildRequires: perl(ExtUtils::ParseXS) >= 2.2205
-BuildRequires: perl(ExtUtils::Typemaps) >= 1.00
-BuildRequires: perl(ExtUtils::XSpp) >= 0.11
+BuildRequires: perl(File::Spec)
BuildRequires: perl(Module::Build) >= 0.26
BuildRequires: perl(Test::More)
-BuildRequires: perl(warnings)
-BuildRequires: perl(File::Spec)
-BuildRequires: perl(File::Basename)
-BuildRequires: perl(XSLoader)
-Requires: perl(Digest::MD5)
-Requires: perl(ExtUtils::CBuilder)
Requires: perl(ExtUtils::CppGuess) >= 0.04
Requires: perl(ExtUtils::ParseXS) >= 2.2205
Requires: perl(ExtUtils::Typemaps) >= 1.00
Requires: perl(ExtUtils::XSpp) >= 0.11
-Requires: perl(Module::Build) >= 0.26
-Requires: perl(File::Spec)
Requires: perl(File::Basename)
-Requires: perl(XSLoader)
+Requires: perl(File::Spec)
+Requires: perl(Module::Build) >= 0.26
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+# Filtering unversioned requires
+%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}^perl\\(Module::Build\\)$
+%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}^perl\\(ExtUtils::CppGuess\\)$
+
%description
This subclass of Module::Build adds some tools and processes to make it
easier to use for wrapping C++ using XS++ (ExtUtils::XSpp).
@@ -44,7 +37,6 @@
%install
./Build install destdir=%{buildroot} create_packlist=0
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
%{_fixperms} %{buildroot}/*
@@ -52,11 +44,22 @@
./Build test
%files
-%doc Changes META.json README
+%doc Changes README
%{perl_vendorlib}/*
%{_mandir}/man3/*
%changelog
+* Thu Dec 20 2012 Miro Hrončok <miro(a)hroncok.cz> - 0.12-3
+- Removed deleting empty dirs in %%install section
+- Do not package META.json
+- Removed (B)Rs: perl(XSLoader), perl(Digest::MD5), perl(ExtUtils::CBuilder)
+- Removed BRs: perl(ExtUtils::ParseXS), perl(ExtUtils::Typemaps),
perl(ExtUtils::XSpp)
+- Filter unversioned Requires: perl(Module::Build), perl(ExtUtils::CppGuess)
+- Sort (B)Rs lexicografically
+
+* Fri Nov 16 2012 Miro Hrončok <miro(a)hroncok.cz> - 0.12-2
+- Removed BRs provided by perl package
+
* Wed Nov 14 2012 Miro Hrončok <miro(a)hroncok.cz> 0.12-1
- New version.
TODO: Remove deleting empty directories in %install section. Modern
Module::Build does not leave empty directories.
-find %{buildroot} -depth -type d
-exec rmdir {} 2>/dev/null \;
Ok.
TODO: Do not package META.json. It's useful only for this package
packager.
-%doc Changes META.json README
+%doc Changes README
Ok.
TODO: Sort (build-)requires lexicographically. It will ease future
maintenance.
Ok.
FIX: Remove useless `perl(XSLoader)' (build-)dependency.
-BuildRequires: perl(XSLoader)
Ok.
FIX: Remove useless `perl(Digest::MD5)' (build-)dependency.
-BuildRequires: perl(Digest::MD5)
Ok.
FIX: Remove useless `perl(ExtUtils::CBuilder)'
(build-)dependency.
-BuildRequires: perl(ExtUtils::CBuilder)
Ok.
FIX: Remove BuildRequires `perl(ExtUtils::ParseXS))'. It's
not needed at build-time.
-BuildRequires: perl(ExtUtils::ParseXS) >= 2.2205
Ok.
FIX: Remove BuildRequires `perl(ExtUtils::Typemaps)'. It's
not needed at build-time.
-BuildRequires: perl(ExtUtils::Typemaps) >= 1.00
Ok.
FIX: Remove BuildRequires `perl(ExtUtils::XSpp)'. It's not
needed at build-time.
-BuildRequires: perl(ExtUtils::XSpp) >= 0.11
Ok.
All tests pass. Ok.
$ rpmlint perl-Module-Build-WithXSpp.spec
../SRPMS/perl-Module-Build-WithXSpp-0.12-3.fc19.src.rpm
../RPMS/noarch/perl-Module-Build-WithXSpp-0.12-3.fc19.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
FIX: Remove unneeded `perl(Digest::MD5)',
`perl(ExtUtils::CBuilder)', `perl(XSLoader)'.
-Requires:
perl(Digest::MD5)
Ok.
TODO: Filter unversioned `perl(ExtUtils::CppGuess)' run-time
dependency.
TODO: Filter unversioned `perl(Module::Build)' run-time dependency.
$ rpm -q
--requires -p
../RPMS/noarch/perl-Module-Build-WithXSpp-0.12-3.fc19.noarch.rpm |sort |uniq -c
1 perl(ExtUtils::CppGuess) >= 0.04
1 perl(ExtUtils::ParseXS) >= 2.2205
1 perl(ExtUtils::Typemaps) >= 1.00
1 perl(ExtUtils::XSpp) >= 0.11
1 perl(File::Basename)
1 perl(File::Spec)
1 perl(Module::Build) >= 0.26
1 perl(:MODULE_COMPAT_5.16.2)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-Module-Build-WithXSpp-0.12-3.fc19.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F19
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=4831139). Ok.
Package is good.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=P729lED4zP&a=cc_unsubscribe