Component: Package Review
Artem <ego.cordatus(a)gmail.com> has canceled Package Review
<package-review(a)lists.fedoraproject.org>'s request for Artem
Bug 1751216: Review Request: xlunch - Graphical app launcher for X with minimal
--- Comment #7 from Artem <ego.cordatus(a)gmail.com> ---
(In reply to Artur Frenszek-Iwicki from comment #4)
Fedora ships OpenSans (open-sans-fonts), why change this?
Because of consistency and Cantarell more system-widely used also canonical for
GNOME DE. Just wanted better defaults. But if you insist i'll accept this easy
since and we can keep upstream defaults here.
Also, if "otherwise it won't run", then the font
package should go in
Requires:, not Recommends:.
Good point. Now 'abattis-cantarell-fonts' hard dep and there should'n be any
issue since it availablin even in CentOS7
># "Error generating new entries"" for key
"Exec" in group "Desktop Entry"
contains a reserved character '$' outside of a quote
># error: required key "Type" in group "Desktop
Entry" is not present
I looked at the .desktop file and I think the best way to solve this
be to extract the whole chain of commands into a helper shell script, and
then just launch that script from the .desktop file.
I though this as well, but TBH i've lost interest a little bit to this package
since i've packaged Ulauncher and sgtk-menu for Fedora. But i fixed that and
upstreamed, see links in SPEC file.
Also, taking a look at the upstream Makefile - the files are
"cp". Please consider patching this (and possibly sending the patch
upstream) to use "cp -p" so that file timestamps are preserved.
Ok, this is in TODO area.
(In reply to Robert-André Mauchin 🐧 from comment #6)
- Is there files in this? That you would need to
Yep. Fixed. Also this a directory, so now this look like this:
There is still some issues (new) but it works.