https://bugzilla.redhat.com/show_bug.cgi?id=2312637

Fedora Review Service fedora-review-bot@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/as | |n1-rs

--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8025100 (failed)

Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.

https://bugzilla.redhat.com/show_bug.cgi?id=2312637 Bug 2312637 depends on bug 2312629, which changed state.

Bug 2312629 Summary: Review Request: rust-rusticata-macros - Helper macros for Rusticata https://bugzilla.redhat.com/show_bug.cgi?id=2312629

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA

https://bugzilla.redhat.com/show_bug.cgi?id=2312637 Bug 2312637 depends on bug 2312632, which changed state.

Bug 2312632 Summary: Review Request: rust-asn1-rs-derive - Derive macros for the asn1-rs crate https://bugzilla.redhat.com/show_bug.cgi?id=2312632

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA

https://bugzilla.redhat.com/show_bug.cgi?id=2312637

--- Comment #3 from Davide Cavalca davide@cavalca.name --- [fedora-review-service-build]

https://bugzilla.redhat.com/show_bug.cgi?id=2312637

Marc-Andre Lureau marcandre.lureau@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |rust-asn1-rs CC| |marcandre.lureau@redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=2312637

Fabio Valentini decathorpe@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com

--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- (In reply to Marc-Andre Lureau from comment #5)

@davide@cavalca.name you need to update the buildrequires list: %if %{with check} BuildRequires: crate(bitvec) BuildRequires: crate(cookie-factory) BuildRequires: crate(futures) BuildRequires: crate(futures-macro) BuildRequires: crate(futures-executor) BuildRequires: crate(num-bigint) BuildRequires: crate(slab) BuildRequires: crate(time) BuildRequires: crate(time-macros) %endif

I don't know why this is here or why you both think it's required - adding crate dependencies like this is wrong either way, especially without lower / upper version bounds.

If the dependencies are missing from the crate, they should be added in Cargo.toml (how that is possible, I don't know), or if the dependencies are needed for tests and they're pulled in by optional / non-default features, add the "-f foo,bar" or even "-a" flag to "%cargo_*" macros (except %cargo_prep) instead.

https://bugzilla.redhat.com/show_bug.cgi?id=2312637

Davide Cavalca davide@cavalca.name changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(davide@cavalca.na | |me) |

--- Comment #7 from Davide Cavalca davide@cavalca.name --- Spec URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs/rust-asn1-rs.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs/rust-asn1-rs-0.6.2-1.f...

Changelog: - enable features we need for tests

https://bugzilla.redhat.com/show_bug.cgi?id=2312637

Fabio Valentini decathorpe@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |tfanelli@redhat.com

--- Comment #10 from Fabio Valentini decathorpe@gmail.com --- *** Bug 2330103 has been marked as a duplicate of this bug. ***

https://bugzilla.redhat.com/show_bug.cgi?id=2312637

Fabio Valentini decathorpe@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST

--- Comment #12 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.

You might want to exclude the "doc/" folder but it doesn't hurt to be present since it's just some markdown files.

✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)

https://bugzilla.redhat.com/show_bug.cgi?id=2312637

Cole Robinson crobinso@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2330124

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2330124 [Bug 2330124] Review Request: rust-oid-registry - Rust Object Identifier (OID) database

https://bugzilla.redhat.com/show_bug.cgi?id=2312637

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-45784f5560 (rust-asn1-rs-0.6.2-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-45784f5560