Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
Summary: Review Request: php-magickwand Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: redhat-bugzilla@linuxnetz.de QAContact: fedora-package-review@redhat.com
Spec URL: http://labs.linuxnetz.de/bugzilla/php-magickwand.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/php-magickwand-0.1.8-2.src.rpm Description: MagickWand for PHP is a native PHP interface to the new ImageMagick MagickWand API. It is an almost complete port of the ImageMagick C API, excluding some X-Server related functionality, and progress monitoring.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
redhat-bugzilla@linuxnetz.de changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
redhat-bugzilla@linuxnetz.de changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |163776 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |j.w.r.degoede@hhs.nl OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-06-11 02:06 EST ------- MUST: ===== * rpmlint output is: E: php-magickwand binary-or-shlib-defines-rpath /usr/lib64/php/modules/magickwand.so ['/usr/lib64'] W: php-magickwand non-conffile-in-etc /etc/php.d/magickwand.ini W: php-magickwand wrong-file-end-of-line-encoding /usr/share/doc/php-magickwand-0.1.8/README All 3 these messages must be fixed. * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok, license file included * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel-x86_64 * BR: ok * No locales * No shared libraries (its a plugin) * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed, no libs / .la files. * no gui -> no .desktop file required
MUST fix: ========= * all 3 rpmlint complaints let me know if you need help with any of them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From redhat-bugzilla@linuxnetz.de 2006-06-11 16:12 EST ------- I can't reproduce the binary-or-shlib-defines-rpath on my ix86 system, looks like it is x86_64 related. Is adding --disable-rpath to %configure enough or will I have to something like this - used in php-extras, IIRC:
# Cause libtool to avoid passing -rpath when linking # (this hack is well-known as "libtool rpath workaround") sed -i 's|^hardcode_libdir_flag_spec|hardcode_libdir_flag_spec=" - D__LIBTOOL_IS_A_FOOL__ "|' libtool
And AFAIK, only php-extras is using this hack of the php packages in Extras...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-06-11 16:40 EST ------- Neither trick works :| I'll look into this for you, but it might take a day or 2 before I find the time for this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-06-13 04:29 EST ------- What a (buggy) bitch, anyway the easiest (and sofar only) way to fix this is to add: export PHP_RPATH=no to %setup before %configure.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From redhat-bugzilla@linuxnetz.de 2006-06-13 07:56 EST ------- Okay, updated php-magickwand is available. Typical fixes were also applied to php-idn, my other php package. There's no rpmlint output anymore on my x86_32 system.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |j.w.r.degoede@hhs.nl OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-06-14 03:16 EST ------- Restoring work lost due to the BZ crash.
This package has had a full review, if I remember correctly the only MUST fix item were 3 rpmlint messages. One of the was related to rpath problems and turned out to only show on 64 bit archs. The fix for the rpath problem is to add: export PHP_RPATH=no before: %configure under: %setup
Robert also posted a new version, available from: http://labs.linuxnetz.de/bugzilla/
Which I've just fully re-reviewed, all is good: Approved!
Leaving the blockerbugs as is for now untill we've got 2 other packages sorted out and I'm going to sponsor you having a package blocking FE-ACCEPT without it being imported is going to make some scripts which do automated sanity checks on the whole review process unhappy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From redhat-bugzilla@linuxnetz.de 2006-06-17 08:04 EST ------- Problem mentioned in bug #194479 is now resolved for php-magickwand, too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778, 177841 |163779 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From redhat-bugzilla@linuxnetz.de 2006-06-18 10:42 EST ------- The package failed building in FC5 but was successful in devel, see:
- http://buildsys.fedoraproject.org/logs/fedora-5-extras/11170-php-magickwand-.... 1.8-2.fc5/i386/build.log - http://buildsys.fedoraproject.org/logs/fedora-development-extras/11169-php- magickwand-0.1.8-2.fc6/i386/build.log
When installing ImageMagick-6.2.5.4-4.2.1.fc5.3, I'm able to reproduce the problem, when using my own local rebuild of same version, I'm not. But I've to say, that my local system isn't more devel rather FC5...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-06-18 15:36 EST ------- Hmm, the FC-5 build.log isn't being helpfull. Please do a FC-5 mock build (which should give the same error) and then attach the config.log from the mock builddir.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
redhat-bugzilla@linuxnetz.de changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |195864
------- Additional Comments From redhat-bugzilla@linuxnetz.de 2006-06-18 18:35 EST ------- Ha, found the shit: ImageMagick 6.2.5.4 got every linking information hardcoded into Wand-config and so is always linking against freetype-devel, but freetype- devel is unfortunately no build requirement of ImageMagick-devel.
I opened bug #195864, because adding the requirement to php-magickwand is IMHO the wrong way as every application depending on ImageMagick(-devel) will fail because of this...
I'll rebuild php-magickwand for FC-5 branch, when bug #195864 is resolved and pushed to Updates directory.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-06-19 11:36 EST ------- You could also concider adding a freetype-devel BR to the FC-5 spec file as a workaround for now and remove it later when this issue gets really fixed. (When removing don't request a build unless there are other _real_ changes).
Handle this however you like, Im just trying to give you some options.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-07-15 01:10 EST ------- Closing since this has been build for Development, currently its showing up in: http://fedoraproject.org/wiki/Extras/PackageStatus
As needs cleanup, so I'm cleaning up :)
BTW, did you verify this package matches the recent "released" php packaging guidelines?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194470
------- Additional Comments From redhat-bugzilla@linuxnetz.de 2006-07-15 06:17 EST ------- As per current status of http://fedoraproject.org/wiki/Packaging/PHP, PHP RPM packages like this aren't handled, yet. And of my understanding, any package not listed at http://pecl.php.net/, isn't a PHP PECL package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-magickwand
https://bugzilla.redhat.com/show_bug.cgi?id=194470
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
Bug 194470 depends on bug 195864, which changed state.
Bug 195864 Summary: ImageMagick-devel doesn't require freetype-devel https://bugzilla.redhat.com/show_bug.cgi?id=195864
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |WORKSFORME
package-review@lists.fedoraproject.org