[Bug 2322418] New: Review Request: rust-auto_enums - Library for to allow multiple return types by automatically generated enum
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Bug ID: 2322418 Summary: Review Request: rust-auto_enums - Library for to allow multiple return types by automatically generated enum Product: Fedora Version: rawhide URL: https://crates.io/crates/auto_enums Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: fedora@lecris.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://lecris.fedorapeople.org/reviews/rust-auto_enums/rust-auto_enums.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-auto_enums/rust-auto_enums-0.8....
Description: A library for to allow multiple return types by automatically generated enum.
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #1 from Cristian Le fedora@lecris.me --- Created attachment 2054249 --> https://bugzilla.redhat.com/attachment.cgi?id=2054249&action=edit rust2rpm.toml
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2322417
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2322417 [Bug 2322417] Review Request: rust-derive_utils - Procedural macro helper for easily writing derive macros for enums
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2253820
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2253820 [Bug 2253820] rust-mockall-0.13.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8186337 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2322418 Bug 2322418 depends on bug 2322417, which changed state.
Bug 2322417 Summary: Review Request: rust-derive_utils - Procedural macro helper for easily writing derive macros for enums https://bugzilla.redhat.com/show_bug.cgi?id=2322417
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-auto_enums
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #7 from Cristian Le fedora@lecris.me --- Thank you for the review, Fabio
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-21e2a892a4 (rust-auto_enums-0.8.6-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-21e2a892a4
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |rust-auto_enums-0.8.6-1.fc4 | |2
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-12-17 16:49:48
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-21e2a892a4 (rust-auto_enums-0.8.6-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-54caa81186 (rust-auto_enums-0.8.6-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-54caa81186
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-54caa81186 (rust-auto_enums-0.8.6-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-54caa81186
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7e989a87ec (rust-auto_enums-0.8.6-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7e989a87ec
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-54caa81186 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-54caa81186` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-54caa81186
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7e989a87ec has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7e989a87ec` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7e989a87ec
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-54caa81186 (rust-auto_enums-0.8.6-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7e989a87ec (rust-auto_enums-0.8.6-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8362133 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Keywords|AutomationTriaged | Status|NEW |POST Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- I really don't like it when Cargo.toml is manipulated in two different ways (both patch *and* tomcli), but that's your choice.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (some tests that don't work disabled) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2322418
--- Comment #6 from Cristian Le fedora@lecris.me --- I usually go for `tomcli` patches for persistent patches and normal `patch` for ephemeral or spec-changing ones. I believe I chose the latter because it is necessary, but also manually patching out the tests since they are persistently unsupported. I guess I could also change the `features.enable-all` and hide the relevant ones, but I want to see more how this project evolves in its releases on how these features change.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com