https://bugzilla.redhat.com/show_bug.cgi?id=1987564
Bug ID: 1987564 Summary: Review Request: <main package name here> - <short summary here> Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: bilselergun@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mong... SRPM URL: https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mong... Description: It is a RPM package that can save incremental backups for the MogoDb and restore them in point-time recovery. Fedora Account System Username:
https://bugzilla.redhat.com/show_bug.cgi?id=1987564
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |code@musicinmybrain.net Doc Type|--- |If docs needed, set a value Flags| |needinfo?(bilselergun@gmail | |.com)
--- Comment #1 from Ben Beasley code@musicinmybrain.net --- Please fix the review title by filling in the template values, and fill in your FAS username.
https://bugzilla.redhat.com/show_bug.cgi?id=1987564
ergün bilselergun@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|rawhide |34 Summary|Review Request: <main |Review Request: |package name here> - <short |<mongoInc-backup-0.1-1.fc34 |summary here> |.x86_64.rpm> - | |<mongoInc-backup> CC| |bilselergun@gmail.com Flags|needinfo?(bilselergun@gmail | |.com) |
--- Comment #2 from ergün bilselergun@gmail.com --- Fas : erelbi
https://bugzilla.redhat.com/show_bug.cgi?id=1987564
Artur Frenszek-Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl
--- Comment #3 from Artur Frenszek-Iwicki fedora@svgames.pl ---
Spec URL: https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mong... SRPM URL: https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mong...
This is a link to a GitHub downloads page. Please use direct links to the "raw" .spec and .src.rpm files.
License: GNU
GNU is a free software project, not the name of a license. Looking at the sources, you meant the GNU General Public License, version 3. Use "GPLv3" here. https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
Group: System Packager: Ergün Elvan Bilsel
Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_section...
mkdir -p $RPM_BUILD_ROOT/etc/mongobackup/ mkdir -p $RPM_BUILD_ROOT/usr/local/bin/ mkdir -p $RPM_BUILD_ROOT/usr/share/licenses/mongoInc-backup/ mkdir -p $RPM_BUILD_ROOT/usr/share/doc/mongoInc-backup/
Do not use hard-coded paths. You should use the appropriate RPM macros instead, e.g. '/usr/share' -> '%{_datadir}'. https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros...
cp /home/ergunbilsel/PycharmProjects/mongoinc/mongoInc-backup-0.1/mongodb-backup.config $RPM_BUILD_ROOT/etc/mongobackup/ ... cp /home/ergunbilsel/PycharmProjects/mongoinc/mongoInc-backup-0.1/THANKS $RPM_BUILD_ROOT/usr/share/doc/mongoInc-backup/
1. Uh... this will fail when run anywhere else apart from your machine. 2. This is done in %prep, whereas it should be done in %install.
https://bugzilla.redhat.com/show_bug.cgi?id=1987564
--- Comment #4 from Ben Cotton bcotton@redhat.com --- This message is a reminder that Fedora Linux 34 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '34'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 34 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
https://bugzilla.redhat.com/show_bug.cgi?id=1987564
Ben Cotton bcotton@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |EOL Status|NEW |CLOSED Last Closed| |2022-06-08 00:14:35
--- Comment #5 from Ben Cotton bcotton@redhat.com --- Fedora Linux 34 entered end-of-life (EOL) status on 2022-06-07.
Fedora Linux 34 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release.
Thank you for reporting this bug and we are sorry it could not be fixed.
package-review@lists.fedoraproject.org