https://bugzilla.redhat.com/show_bug.cgi?id=1310793
--- Comment #3 from Paulo Henrique Rodrigues Pinheiro <paulo(a)sysincloud.it> ---
(In reply to Richard Shaw from comment #2)
A quick spec review on my lunch break...
1. rpmbuild doesn't care but typically %{pre,post,postun,etc}
would be after
%install
OK
2. In %build, why is the debug package being disabled? Typically this
is
only permitted for noarch packages where it doesn't produce anything useful.
I followed the directions of the documentation* to see if it was a recurring
problem, but could not make the debug package be generated.
*
https://fedoraproject.org/wiki/Packaging:Debuginfo?rd=Packaging/Debuginfo
After this, to "silent" rpmlint, I put a strip in make install.
3a. A license file only needs to be included in one package assuming
the
other requires it (in this case -devel requires the base package)
OK, I put this because rpmlint give-me "no-documentation" :)
3b. License files should use the %license macro rather than %doc.
3c. Since a readme file is provided it should be included in the base
package with %doc.
There's no README.md, only license.txt...
So all that to say the base package should be updated to:
%license license.txt
%doc README.md
Can I leave rpmlint with these warnings? My output:
[paulohrpinheiro@localhost SPECS]$ rpmlint unqlite.spec
../RPMS/x86_64/unqlite-*
unqlite.x86_64: W: no-documentation
unqlite-devel.x86_64: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
4. Typo in the description at the beginning of the -devel package.
OK
Thank you. The files are updated in original links:
Spec URL:
https://raw.githubusercontent.com/paulohrpinheiro/fedora-rpm-unqlite/mast...
SRPM URL:
https://github.com/paulohrpinheiro/fedora-rpm-unqlite/raw/master/unqlite-...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component