Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: vobject - A python library for manipulating vCard and vCalendar
files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601
panemade(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |panemade(a)gmail.com
------- Additional Comments From panemade(a)gmail.com 2006-06-25 23:18 EST -------
Not an official review as I'm not yet sponsored
Mock build for development i386 is suceesfull with some warnings
+ /usr/bin/python setup.py build
/usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution
option: 'zip_safe'
warnings.warn(msg)
/usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution
option: 'install_requires'
warnings.warn(msg)
MUST Items:
- MUST: rpmlint shows no error on i386
- MUST: dist tag is present
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package vobject, in the
format vobject.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license
Apache Software License.
- MUST: The License field in the package vobject.spec file did not match
any file in tarball.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- MUST: This package used macros.
- MUST: Document files are included like README.txt
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is correct
What you Need:-
* You dont need to have
Requires: python-abi = %(%{__python} -c "import sys ; print
sys.version[:3]")
as this is only for rpms targetting for FC3 or prior.
* Add License file in tarball if you can alter the tarball contents.
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.