https://bugzilla.redhat.com/show_bug.cgi?id=1499501
Bug ID: 1499501 Summary: Review Request: gocomplete - A tool for bash writing bash completion in Go (Golang) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: esm@logic.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://fedorapeople.org/~logic/gocomplete/gocomplete.spec SRPM URL: https://fedorapeople.org/~logic/gocomplete/gocomplete-0-0.1.20170908git88e59... Description: A tool for bash writing bash completion in Go (Golang) Fedora Account System Username: logic
Koji scratch build (with expected ppc64 arch failure): https://koji.fedoraproject.org/koji/taskinfo?taskID=22322498
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- This is a binary package, not used as a library, thus I don't think you need to generate the -devel and -unit-test-devel subpackages.
Either just flick the devel and unit-test switches in the header:
# Generate devel rpm %global with_devel 0 # Build project from bundled dependencies %global with_bundled 0 # Build with debug info rpm %global with_debug 1 # Run tests in check section %global with_check 1 # Generate unit-test rpm %global with_unit_test 0
Or better remove the whole gofed cruft which isn't needed.
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
--- Comment #2 from Ed Marshall esm@logic.net --- Actually, while gocomplete is a standalone executable (which generates bash/zsh completion for the "go" executable), it mostly exists as a useful example of using the library (I built it because Vault has a dependency on the library).
I'd almost be inclined to go the other direction (drop the gocomplete executable entirely, and just build the library), but had the thought that someone might find it useful, and it's trivial to build as part of this.
Your thoughts? I'm completely flexible, as long as the end result includes the library. :)
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Ok, I think you should keep the binary then, in case someone also needs it.
Package accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gocomplete
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- gocomplete-0-0.1.20170908git88e5976.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f74ce72ede
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- gocomplete-0-0.1.20170908git88e5976.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-290e6893ec
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- gocomplete-0-0.1.20170908git88e5976.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-290e6893ec
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- gocomplete-0-0.1.20170908git88e5976.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f74ce72ede
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-10-16 20:15:08
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- gocomplete-0-0.1.20170908git88e5976.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords| |Reopened
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- gocomplete-0-0.2.20170908git88e5976.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-290e6893ec
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
Ed Marshall esm@logic.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1250466
--- Comment #11 from Ed Marshall esm@logic.net --- EPEL7 depends on #1250466.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1250466 [Bug 1250466] Tracker for golang-github-hashicorp-go-multierror
https://bugzilla.redhat.com/show_bug.cgi?id=1499501 Bug 1499501 depends on bug 1250466, which changed state.
Bug 1250466 Summary: Tracker for golang-github-hashicorp-go-multierror https://bugzilla.redhat.com/show_bug.cgi?id=1250466
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |MODIFIED Resolution|ERRATA |---
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- gocomplete-0-0.2.20170908git88e5976.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1499501
Ed Marshall esm@logic.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2017-10-16 20:15:08 |2017-11-20 23:22:27
https://bugzilla.redhat.com/show_bug.cgi?id=1499501 Bug 1499501 depends on bug 1250466, which changed state.
Bug 1250466 Summary: Tracker for golang-github-hashicorp-go-multierror https://bugzilla.redhat.com/show_bug.cgi?id=1250466
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |EOL
package-review@lists.fedoraproject.org