Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250893
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: s.adam@diffingo.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://www.diffingo.com/downloads/audio-convert-mod/audio-convert-mod.spec SRPM URL: http://www.diffingo.com/downloads/audio-convert-mod/audio-convert-mod-3.45.0... Description: audio-convert-mod is a simple audio file converter supporting various formats via external binaries. It facilitates the batch conversion of audio files from one format to another by access from the menu or by the user script where at a right-click files can be converted at once. It also supports file tags/metadata where applicable.
rpmlint is silent on the source and binary rpms.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250893
jpmahowald@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |jpmahowald@gmail.com Flag| |fedora-review?
------- Additional Comments From jpmahowald@gmail.com 2007-08-24 10:36 EST ------- License: GPL is not sufficient, you have to specify which one, as per http://fedoraproject.org/wiki/Licensing
I notice source files specifying GPL 2 or later.
You have your python macro backwards: get_python_lib(1) is how the sitearch macro is defined. Really it should be get_python_lib() for a noarch. However, in the Makefile, it expands $(LIBDIR). I suggest fixing this to use python to PYMODDIR.
There is an uninstall script. Remove, rpm is going to manage this.
Does not use restricted code, rather calls programs if they exist. Good.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/show_bug.cgi?id=250893
------- Additional Comments From s.adam@diffingo.com 2007-08-25 12:18 EST ------- I've made a new new release 3.45.1 (fixes the Makefiles) and adds a few new features. In terms of the spec, I reverted to sitelib rather than sitearch.
SPEC: http://www.diffingo.com/downloads/audio-convert-mod/audio-convert-mod.spec SRPM: http://www.diffingo.com/downloads/audio-convert-mod/audio-convert-mod-3.45.1...
rpmlint is still silent on both.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/show_bug.cgi?id=250893
jpmahowald@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From jpmahowald@gmail.com 2007-09-01 02:55 EST ------- Good: + follows python template + name version release good + license (GPLv2+) + source matches upstream + builds on x86_64 + rpmlint clean + %clean section + .desktop file
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/show_bug.cgi?id=250893
------- Additional Comments From s.adam@diffingo.com 2007-09-01 15:02 EST ------- New Package CVS Request ======================= Package Name: audio-convert-mod Short Description: A simple audio file converter supporting many formats Owners: firewing Branches: FC-6 F-7 InitialCC: firewing Cvsextras Commits: no
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/show_bug.cgi?id=250893
s.adam@diffingo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From s.adam@diffingo.com 2007-09-01 16:43 EST ------- Forgot to set the flag...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/show_bug.cgi?id=250893
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-09-03 14:21 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/show_bug.cgi?id=250893
s.adam@diffingo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From s.adam@diffingo.com 2007-09-04 17:51 EST ------- Built - Thanks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/show_bug.cgi?id=250893
------- Additional Comments From updates@fedoraproject.org 2007-09-04 18:11 EST ------- audio-convert-mod-3.45.1-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/show_bug.cgi?id=250893
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |ERRATA Fixed In Version| |3.45.1-1.fc7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats
https://bugzilla.redhat.com/show_bug.cgi?id=250893
s.adam@diffingo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|ERRATA |NEXTRELEASE
package-review@lists.fedoraproject.org