Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225674

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limburgher@gmail.com AssignedTo|nobody@fedoraproject.org |limburgher@gmail.com Flag| |fedora-review?

--- Comment #1 from Jon Ciesla limburgher@gmail.com 2012-04-05 11:00:16 EDT --- Good:

- rpmlint checks return:

dasher.spec:6: W: non-standard-group Desktop/Accessibility The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "Unspecified", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

Fix. Should be User Interface/Desktops

dasher.spec:62: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: line 62) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.

Fix.

dasher.x86_64: E: incorrect-fsf-address /usr/share/doc/dasher-4.10.1/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.

Ignore, but maybe file upstream.

dasher.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/dasher.schemas A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.

Ignore.

- package meets naming guidelines - package meets packaging guidelines - license ( GPLv2 ) OK, text in %doc, matches source MUSTFIX should be GPLv2+ - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file

So it's just the rpmlint things. Also, 4.11 is out. Since it's all so minor I'll do it all shortly unless you object.