https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Bug ID: 1538824 Summary: Review Request: python-grabbit - Get grabby with file trees Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sanjay.ankur@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ankursinha.fedorapeople.org/python-grabbit/python-grabbit.spec SRPM URL: https://ankursinha.fedorapeople.org/python-grabbit/python-grabbit-0.1.0-1.fc...
Description: Grabbit is a lightweight Python package for simple queries over filenames within a project. It's geared towards projects or applications with highly structured filenames that allow useful queries to be performed without having to inspect the file metadata or contents.
Fedora Account System Username: ankursinha
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1534067
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 [Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1534799
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1534799 [Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Summary: %{sum}
%{sum} hasn't been defined anywhere, please correct this.
- Please consider asking upstream for a LICENCE file.
- You should notify upstream about their failing tests.
Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or generated". 98 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-grabbit/review- python-grabbit/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: python2-grabbit (summary), python3-grabbit (summary) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-grabbit , python3-grabbit [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python2-grabbit-0.1.0-1.fc27.noarch.rpm python3-grabbit-0.1.0-1.fc27.noarch.rpm python-grabbit-0.1.0-1.fc27.src.rpm python2-grabbit.noarch: W: unexpanded-macro Summary(C) %{sum} python2-grabbit.noarch: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments python3-grabbit.noarch: W: unexpanded-macro Summary(C) %{sum} python3-grabbit.noarch: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments python-grabbit.src: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments 3 packages and 0 specfiles checked; 0 errors, 5 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1538824 Bug 1538824 depends on bug 1534799, which changed state.
Bug 1534799 Summary: Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS https://bugzilla.redhat.com/show_bug.cgi?id=1534799
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
--- Comment #2 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Thanks for the review. I'll make an SCM request and update the bits you've pointed out.
Cheers, Ankur!
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
--- Comment #3 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Robert,
Could you please unset and set the fedora-review flag again? Turns out fedpkg request-repo doesn't work if the review was approved more than 60 days ago.
Sorry about this.
Cheers, Ankur
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review?
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- Sure!
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-grabbit
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-grabbit-0.2.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c29bd76a34
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-grabbit-0.2.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ec02c2917
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-grabbit-0.2.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c29bd76a34
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-grabbit-0.2.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ec02c2917
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-07-16 13:36:13
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-grabbit-0.2.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1538824
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-grabbit-0.2.0-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org