https://bugzilla.redhat.com/show_bug.cgi?id=2091296
Bug ID: 2091296 Summary: Review Request: fastnetmon - Volumetric DDoS detection tool Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: pavel.odintsov@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Hello!
I'm Pavel Odintsov and I would like to introduce our DDoS detection tool into Fedora: https://github.com/pavel-odintsov/fastnetmon
It's my very first package and I would love to have sponsor for it.
xvitaly provided great deal of help with SPEC file and I'm very thankful for assistance.
We're part of Debian, Ubuntu and FreeBSD and our build system is well prepared for packaging.
I have added my package for CORP and it builds well: https://copr.fedorainfracloud.org/coprs/odintsov/FastNetMon/packages/
Then I did build with Koji and it's successful too: https://koji.fedoraproject.org/koji/taskinfo?taskID=87602822
Description: FastNetMon is an extremely versatile and lightning fast volumetric DDoS detection tool with sFlow, Netflow, IPFIX and port mirror support.
Fedora Account System Username: odintsov
Spec URL: https://raw.githubusercontent.com/pavel-odintsov/fastnetmon/master/src/fastn...
SRPM URL: https://download.copr.fedorainfracloud.org/results/odintsov/FastNetMon/fedor...
Thank you!
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |vitaly@easycoding.org Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |vitaly@easycoding.org
--- Comment #1 from Vitaly Zaitsev vitaly@easycoding.org --- I will review this package and sponsor you to Fedora.
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #2 from Vitaly Zaitsev vitaly@easycoding.org ---
fastnetmon_fedora.spec
SPEC must have the same name as the package name, i.e. fastnetmon.spec.
- Saturday May 27 2022 Pavel Odintsov pavel.odintsov@gmail.com - 1.2.2-1
error: bad date in %changelog: Saturday May 27 2022 Pavel Odintsov pavel.odintsov@gmail.com - 1.2.2-1
Please fix this. The correct changelog line should look like this:
* Fri May 27 2022 Pavel Odintsov pavel.odintsov@gmail.com - 1.2.2-1
Source0: https://github.com/pavel-odintsov/fastnetmon/archive/master.tar.gz
Please use tagged version or switch to the snapshots packaging, as described here: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snaps...
%sysusers_create_compat src/fastnetmon.sysusers
fastnetmon.sysusers must be a part of the SRPM package.
Add it as Source1: fastnetmon.sysusers, because it will be expanded during the build process to a scriptlet.
%global fastnetmon_user root %global fastnetmon_group %{fastnetmon_user} %attr(700,%{fastnetmon_user},%{fastnetmon_group}) %dir %{fastnetmon_attackdir}
Root user here, but fastnetmon in fastnetmon.sysusers. Should be fixed.
%global fastnetmon_project_name fastnetmon %global fastnetmon_company FastNetMon LTD
Not used. Can be removed.
Provides: fastnetmon
Should be removed, because it has the same name as the main project. Will be exported automatically.
%global _vpath_srcdir src
Can be replaced with `-S src` parameter of the %cmake macro.
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #3 from Pavel Odintsov pavel.odintsov@gmail.com --- Hello!
Thank you so much for your feedback.
I've addressed all your recommendations: https://github.com/pavel-odintsov/fastnetmon/blob/master/src/packaging/fedor...
I've switched master build to specific commit which includes stable build 1.2.1 with Fedora specific commits and changes.
Source RPM file is here: https://output.circle-artifacts.com/output/job/ec64b649-29a1-4bb9-93e9-4a09b...
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #4 from Vitaly Zaitsev vitaly@easycoding.org ---
%global fastnetmon_commit 420e7b873253fdc1b52b517d9c28db39bf384427 Version: 1.2.1
Version tag must include commit information. Check this as an example:
- https://src.fedoraproject.org/rpms/purple-hangouts/blob/rawhide/f/purple-han... - https://src.fedoraproject.org/rpms/purple-hangouts/blob/rawhide/f/purple-han...
I suggest the following:
%global commit0 420e7b873253fdc1b52b517d9c28db39bf384427 %global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) %global date 20220528
Release: 1.%{date}git%{shortcommit0}%{?dist}
When a new tagged version will be released, you should remove these lines and use standard releases.
Summary: A high performance DoS/DDoS load analyzer built on top of multiple packet capture engines (NetFlow, IPFIX, sFlow, PCAP).
The final dot must be removed.
%global fastnetmon_project_name fastnetmon
Not used. Can be removed.
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #5 from Pavel Odintsov pavel.odintsov@gmail.com --- Thank you! I appreciate your help.
I've applied all recommendations.
New SPEC: https://github.com/pavel-odintsov/fastnetmon/blob/master/src/packaging/fedor...
New source RPM: https://output.circle-artifacts.com/output/job/9702f72c-26f3-47b8-a3cd-a7d2b...
I'll remove all revision stuff after 1.2.2 release. I think we can do it sometime this summer.
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #6 from Vitaly Zaitsev vitaly@easycoding.org --- Looks good now.
Please post RAW links (I will use fedora-review tool):
Spec URL: FULL_SPEC_URL SRPM URL: FULL_SRPM_URL
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #7 from Pavel Odintsov pavel.odintsov@gmail.com --- Hello!
Sure.
Spec: https://raw.githubusercontent.com/pavel-odintsov/fastnetmon/master/src/packa...
Source RPM: https://output.circle-artifacts.com/output/job/9702f72c-26f3-47b8-a3cd-a7d2b...
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #8 from Pavel Odintsov pavel.odintsov@gmail.com --- Updated to use template format:
Spec URL: https://raw.githubusercontent.com/pavel-odintsov/fastnetmon/master/src/packa... SRPM URL: https://output.circle-artifacts.com/output/job/9702f72c-26f3-47b8-a3cd-a7d2b...
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #9 from Vitaly Zaitsev vitaly@easycoding.org --- Please add to the %files section:
%license LICENSE %doc README.md SECURITY.md THANKS.md
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #10 from Pavel Odintsov pavel.odintsov@gmail.com --- Thank you for feedback.
Done:
Spec URL: https://raw.githubusercontent.com/pavel-odintsov/fastnetmon/master/src/packa... SRPM URL: https://output.circle-artifacts.com/output/job/b677d247-2c80-46f0-b3d5-96142...
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #11 from Vitaly Zaitsev vitaly@easycoding.org --- Rpmlint output:
fastnetmon.x86_64: E: unknown-key 63ce1682 fastnetmon.x86_64: E: summary-too-long A high performance DoS/DDoS load analyzer built on top of multiple packet capture engines (NetFlow, IPFIX, sFlow, PCAP) fastnetmon.x86_64: W: non-standard-uid /var/log/fastnetmon_attacks fastnetmon fastnetmon.x86_64: W: non-standard-gid /var/log/fastnetmon_attacks fastnetmon fastnetmon.x86_64: E: non-standard-dir-perm /var/log/fastnetmon_attacks 700 fastnetmon.x86_64: W: no-manual-page-for-binary fastnetmon_api_client fastnetmon.x86_64: W: no-manual-page-for-binary fastnetmon_client fastnetmon.x86_64: W: no-manual-page-for-binary fastnetmon fastnetmon.x86_64: W: no-documentation fastnetmon.x86_64: W: log-files-without-logrotate ['/var/log/fastnetmon_attacks'] fastnetmon.x86_64: W: incoherent-version-in-changelog 1.2.1-1 ['1.2.1-1.20220528git420e7b8.fc37', '1.2.1-1.20220528git420e7b8'] fastnetmon.x86_64: E: description-line-too-long A high performance DoS/DDoS load analyzer built on top of multiple packet capture
1. Please shorten the Summary tag. 80 symbols max. 2. Please fix changelog: change 1.2.1-1 with 1.2.1-1.20220528git420e7b8.
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #12 from Vitaly Zaitsev vitaly@easycoding.org --- 3. Please fix also the %description tag by splitting words:
A high performance DoS/DDoS load analyzer built on top of multiple packet capture engines (NetFlow, IPFIX, sFlow, PCAP).
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #13 from Pavel Odintsov pavel.odintsov@gmail.com --- Excellent, applied fixes.
Spec URL: https://raw.githubusercontent.com/pavel-odintsov/fastnetmon/master/src/packa... SRPM URL: https://output.circle-artifacts.com/output/job/9a137a31-8251-4035-b351-5cfa8...
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #14 from Pavel Odintsov pavel.odintsov@gmail.com --- Added leading dot for description and added reasons why we use specific commit:
Spec URL: https://raw.githubusercontent.com/pavel-odintsov/fastnetmon/master/src/packa... SRPM URL: https://output.circle-artifacts.com/output/job/fb2b3eec-9f0b-4140-ae20-1ff8a...
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #15 from Vitaly Zaitsev vitaly@easycoding.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2", "*No copyright* GNU Lesser General Public License", "*No copyright* [generated file]", "MIT License", "BSD 2-Clause License", "ISC License". 201 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/fastnetmon/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in fastnetmon [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/pavel-odintsov/fastnetmon/archive/420e7b873253fdc1b52b517... : CHECKSUM(SHA256) this package : 324dfb37810ec7fbcf5e762cf6ad4fe340a8502f86477483ea38898b5376c95d CHECKSUM(SHA256) upstream package : 324dfb37810ec7fbcf5e762cf6ad4fe340a8502f86477483ea38898b5376c95d
Requires -------- fastnetmon (rpmlib, GLIBC filtered): /bin/sh config(fastnetmon) libabsl_synchronization.so.2111.0.0()(64bit) libboost_program_options.so.1.78.0()(64bit) libboost_thread.so.1.78.0()(64bit) libbson-1.0.so.0()(64bit) libc.so.6()(64bit) libcapnp.so.0.9.1()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgpr.so.24()(64bit) libgrpc++.so.1.46()(64bit) libjson-c.so.5()(64bit) libjson-c.so.5(JSONC_0.14)(64bit) libkj.so.0.9.1()(64bit) liblog4cpp.so.5()(64bit) libm.so.6()(64bit) libmongoc-1.0.so.0()(64bit) libncurses.so.6()(64bit) libpcap.so.1()(64bit) libprotobuf.so.30()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtinfo.so.6()(64bit) rtld(GNU_HASH) shadow-utils systemd
fastnetmon-debuginfo (rpmlib, GLIBC filtered):
fastnetmon-debugsource (rpmlib, GLIBC filtered):
Provides -------- fastnetmon: config(fastnetmon) fastnetmon fastnetmon(x86-64) group(fastnetmon) user(fastnetmon)
fastnetmon-debuginfo: debuginfo(build-id) fastnetmon-debuginfo fastnetmon-debuginfo(x86-64)
fastnetmon-debugsource: fastnetmon-debugsource fastnetmon-debugsource(x86-64)
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name fastnetmon --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: fonts, SugarActivity, Python, Perl, Ocaml, PHP, Haskell, Java, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #16 from Vitaly Zaitsev vitaly@easycoding.org --- LGTM now. Package approved.
You will receive getting started instruction shortly.
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #17 from Pavel Odintsov pavel.odintsov@gmail.com --- Great news. Thank you so much for your time and you effort.
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
--- Comment #18 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fastnetmon
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2022-06-01 15:22:52
package-review@lists.fedoraproject.org