Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226568
Ondrej Vasik <ovasik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|needinfo?(ovasik(a)redhat.com |
|) |
--- Comment #5 from Ondrej Vasik <ovasik(a)redhat.com> 2008-12-12 06:15:53 EDT ---
Thanks for check of spec file sanity...
(In reply to comment #3)
About the package:
- Why is xsltproc required via a path instead of using libxslt? If libxslt
cannot be used, please explain with a comment in the spec.
Fixed, probably accidently introduced when using spec file from tarball ... up
to F-9 libxslt requirements were present, fix now...
- It is recommended not to use %makeinstall, is there a reason to use
it? It
builds fine here with:
No reason, fixed.
- parallel make is not used:
make %{?_smp_mflags}
Fixed
- Is the touch command still needed? If it is, please explain why in
the spec
file or fix it upstream:
touch doc/xmlto.xml doc/xmlif.xml
Not sure why they were touched - introduced between 0.18-6 and 0.18.13 (FC-5
and FC-6) without explanation in ChangeLog ... will remove it
- License Tag should be GPLv2+ according to the header in xmlto.in
Fixed
- License is in the tarball, but not in %doc:
COPYING
- There is more documentation missing:
README ChangeLog AUTHORS NEWS, maybe FAQ if it is planned to add more to this
file in the future
No need for FAQ at the moment, will think about it for future releases.
- Btw. fedorahosted provides a way to distribute releases without
using the
scm, but I do not know how to upload something there:
https://fedorahosted.org/releases/
Ok, thanks for suggestion, I'll probably add sources under fedorahosted svn in
future and
fedorahosted.org/releases for tarballs - xmlto 0.0.21 is already
there...
https://fedorahosted.org/releases/x/m/xmlto/
If you want and permissions are open in cvs, I can fix at least the
issues that
do not need a comment from you. I will then perform a full review later.
I guess just listing issues here should be enough, I'll fix it myself, thanks.
Objections so far mentioned in comment #3 fixed in rawhide build
xmlto-0.0.21-3.fc11
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.