https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Bug ID: 2313507 Summary: Review Request: xapian-haystack - Haystack search backend for xapian Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mkonecny@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/zlopez/xapian-haystack/ep... SRPM URL: https://download.copr.fedorainfracloud.org/results/zlopez/xapian-haystack/ep... Description: Xapian backend for Django-Haystack Xapian-haystack is a backend of Django-Haystack Fedora Account System Username: zlopez
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Michal Konecny mkonecny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mkonecny@redhat.com Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michel@michel-slm.name Assignee|nobody@fedoraproject.org |michel@michel-slm.name Status|NEW |ASSIGNED Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8042161 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #2 from Michal Konecny mkonecny@redhat.com --- Is anything else needed from me on this? As the review link throws 404 for me and the build succeeded.
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #3 from Michel Lind michel@michel-slm.name --- Sorry, didn't end up having time to do this during the conference last week. Not sure what happens to the COPR-generated reviews, it probably failed to run (but the build itself did finish)
There are some issues
Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
Problem: conflicting requests - nothing provides python3dist(xapian) >= 1.4 needed by python3-xapian-haystack-3.1.0-1.fc42.noarch from @commandline
Looks like python3-xapian (from xapian-bindings) is not properly packaged? It does not provide the expected 'python3dist(MODNAME)' dependency
michel in ~/src/fedora ⬢ [f40-packaging] ❯ fedrq pkgs '*xapian*' python3-xapian-1.4.26-2.fc42.x86_64 tcl-xapian-1.4.26-2.fc42.x86_64 xapian-bindings-1.4.26-2.fc42.src xapian-bindings-1.4.26-2.fc42.x86_64 xapian-bindings-ruby-1.4.26-2.fc42.x86_64 xapian-core-1.4.26-1.fc42.i686 xapian-core-1.4.26-1.fc42.src xapian-core-1.4.26-1.fc42.x86_64 xapian-core-devel-1.4.26-1.fc42.i686 xapian-core-devel-1.4.26-1.fc42.x86_64 xapian-core-libs-1.4.26-1.fc42.i686 xapian-core-libs-1.4.26-1.fc42.x86_64
michel in ~/src/fedora took 17s ⬢ [f40-packaging] ❯ fedrq pkgs python3-xapian -F provides python-xapian = 1.4.26-2.fc42 python3-xapian = 1.4.26-2.fc42 python3-xapian(x86-64) = 1.4.26-2.fc42 python3.13-xapian = 1.4.26-2.fc42
- The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL2'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
=> Is this GPL-2.0-only or GPL-2.0-or-later ?
- Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: xapian-haystack.spec should be python-xapian-haystack.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming => as the issue says
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #4 from Michal Konecny mkonecny@redhat.com --- In COPR, I just tried to build it for EPEL9. I will look at building it for rawhide as well.
Will address all the other issues.
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #5 from Michal Konecny mkonecny@redhat.com --- I fixed the license and spec file name issues. I built the package for F42 and encountered the install issue. I opened a bug on the xapian-bindings issue about this https://bugzilla.redhat.com/show_bug.cgi?id=2314414
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #6 from Michal Konecny mkonecny@redhat.com --- I was able to solve https://bugzilla.redhat.com/show_bug.cgi?id=2314414 in latest build of python3-xapian-haystack https://copr.fedorainfracloud.org/coprs/zlopez/xapian-haystack/build/8105726....
So everything should be now fixed. Do I get a green for the package now?
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|michel@michel-slm.name |ngompa13@gmail.com CC| |ngompa13@gmail.com
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- Taking over this review as Michel is on vacation.
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #8 from Neal Gompa ngompa13@gmail.com --- Spec review notes:
Source0: %{url}/archive/refs/tags/%{version}.tar.gz
This should be "%{url}/archive/%{version}/xapian-haystack-%{version}.tar.gz"
%{python3_sitelib}/__pycache__/* %{python3_sitelib}/xapian_backend.py
This should be replaced with "%pycached %{python3_sitelib}/xapian_backend.py"
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |xapian-haystack - Haystack |python-xapian-haystack - |search backend for xapian |Haystack search backend for | |xapian
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #9 from Neal Gompa ngompa13@gmail.com --- The spec file also needs to be renamed to python-xapian-haystack.spec.
You should also consider modernizing this package to follow the current Python packaging guidelines, which are supported on EPEL 9 and above.
Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #10 from Michal Konecny mkonecny@redhat.com --- After some struggling with the packaging guidelines I was able to finally get it to build.
Here is the new spec file: https://download.copr.fedorainfracloud.org/results/zlopez/xapian-haystack/fe...
And here is the successful build on copr: https://copr.fedorainfracloud.org/coprs/zlopez/xapian-haystack/build/8118458...
Let me know if I missed something.
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #11 from Neal Gompa ngompa13@gmail.com ---
BuildRequires: python3dist(django) >= 3.2 BuildRequires: python3dist(django-haystack) >= 2.8 BuildRequires: python3dist(filelock) >= 3.4 BuildRequires: python3dist(setuptools) [...] %{?python_provide:%python_provide python3-xapian-haystack}
Requires: python3dist(django) >= 3.2 Requires: python3dist(django-haystack) >= 2.8 Requires: python3dist(filelock) >= 3.4 Requires: python3-xapian >= 1.4
This can all be dropped since %generate_buildrequires will get the BRs and Requires would be autogenerated (except python3-xapian, that would stick around)
(FYI, pyp2spec produces spec files with the newer style if you want to use that going forward)
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #12 from Michal Konecny mkonecny@redhat.com --- I think I addressed the the last comment in new version of spec file https://download.copr.fedorainfracloud.org/results/zlopez/xapian-haystack/fe...
The file was originally generated by using COPR build from pypi capability and I started with that.
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #13 from Neal Gompa ngompa13@gmail.com --- At this point, it looks good to me.
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
--- Comment #14 from Michal Konecny mkonecny@redhat.com --- Thanks for the review, I will start with repo request right away :-)
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #15 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-xapian-haystack
https://bugzilla.redhat.com/show_bug.cgi?id=2313507
Michal Konecny mkonecny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|RELEASE_PENDING |CLOSED Last Closed| |2024-10-09 11:55:54
--- Comment #16 from Michal Konecny mkonecny@redhat.com --- Build the package for rawhide without issue https://koji.fedoraproject.org/koji/buildinfo?buildID=2565293. Closing review bug.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com