Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ms-anonymouspro-fonts - AnonymousPro fonts
https://bugzilla.redhat.com/show_bug.cgi?id=529196
Summary: Review Request: ms-anonymouspro-fonts - AnonymousPro fonts Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ozamosi@flukkost.nu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://flukkost.nu/msimonson-anonymouspro-fonts.spec SRPM URL: http://flukkost.nu/msimonson-anonymouspro-fonts-1.001-1.fc12.src.rpm Description: Anonymous Pro is a family of fixed-width fonts designed especially with coding in mind. Characters that could be mistaken for one another (O, 0, I, l, 1, etc.) have distinct shapes to make them easier to tell apart in the context of source code.
It has support for most Western and European Latin-based languages, Greek, and Cyrillic. It also includes special “box drawing” characters.
Anonymous Pro is based on an earlier font, Anonymous, which is a TrueType version of Susan Lesch and David Lamkins’ font Anonymous 9, a freeware Macintosh bitmap font.
This is my very first package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dan@danny.cz
--- Comment #1 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-10-17 11:53:05 EDT --- *** Bug 529369 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |nicolas.mailhot@laposte.net Flag| |fedora-review?, | |needinfo?(ozamosi@flukkost. | |nu)
--- Comment #2 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-10-17 12:19:04 EDT --- Very nice submission, please do more!
1. spec is ok
2. you need to use “Anonymous Pro” and not “AnonymousPro” in your fontconfig file (use fc-query <filename> to check the name exported by a font file)
3. you've reversed the substitution rule. Since you're installing “Anonymous Pro” you want to say “if an app asks for « Anonymous », and it is not available, use the installed « Anonymous Pro » instead” and not the reverse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
--- Comment #3 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-10-17 12:20:38 EDT --- 4. also please write a summary that does not include the font name — it's already part of the package name, and CLI or GUI package management tools will always display it next to the summary"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
Robin Sonefors ozamosi@flukkost.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(ozamosi@flukkost. | |nu) |
--- Comment #4 from Robin Sonefors ozamosi@flukkost.nu 2009-10-17 13:21:04 EDT --- Ok, the above complaints have been fixed:
Spec URL: http://flukkost.nu/msimonson-anonymouspro-fonts.spec SRPM URL: http://flukkost.nu/msimonson-anonymouspro-fonts-1.001-2.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nicolas.mailhot@laposte.net |ozamosi@flukkost.nu Flag|fedora-review? |fedora-review+
--- Comment #5 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-10-17 13:55:21 EDT --- It is with great pleasure that I can declare this version golden. Nice work!
᧱᧱᧱ APPROVED ᧱᧱᧱
You can now continue from: http://fedoraproject.org/wiki/Font_package_lifecycle#3.a
If you need sponsorship in the packager group, you can ping me after another of your submissions reaches the “approved” stage.
I hope the process was pleasant, and that it will inspire you to package other fonts for Fedora. Please do not hesitate to suggest improvements to our organisation on the fonts mailing list.
Thank you for your contribution to our font package pool.
⇒ REASSIGNING
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
Robin Sonefors ozamosi@flukkost.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Robin Sonefors ozamosi@flukkost.nu 2009-10-19 15:19:38 EDT --- New Package CVS Request ======================= Package Name: msimonson-anonymouspro-fonts Short Description: A coding-friendly monospace font Owners: ozamosi Branches: F11 F12 InitialCC: fonts-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2009-10-22 00:47:55 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-10-22 11:11:18 EDT --- msimonson-anonymouspro-fonts-1.001-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/msimonson-anonymouspro-fonts-1.001-2....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-10-27 02:28:31 EDT --- msimonson-anonymouspro-fonts-1.001-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |1.001-2.fc11 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-12-02 11:27:06 EDT --- msimonson-anonymouspro-fonts-1.001-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/msimonson-anonymouspro-fonts-1.001-2....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529196
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-12-04 18:36:39 EDT --- msimonson-anonymouspro-fonts-1.001-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org