https://bugzilla.redhat.com/show_bug.cgi?id=1671064
--- Comment #4 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
License tag is fine. Packaging-wise it looks very good, too. I have some
nitpicks below:
1. I suggest listing pkgconfig and include files explicitly to avoid missing
changes from upstream:
--- libldac.spec.orig 2019-01-30 17:40:13.000000000 +0100
+++ libldac.spec 2019-02-07 18:50:43.172939850 +0100
@@ -50,8 +50,11 @@
%{_libdir}/libldacBT_enc.so.%{sonamebase}.*
%files devel
-%{_includedir}/*
-%{_libdir}/pkgconfig/*
+%dir %{_includedir}/ldac
+%{_includedir}/ldac/ldacBT_abr.h
+%{_includedir}/ldac/ldacBT.h
+%{_libdir}/pkgconfig/ldacBT-abr.pc
+%{_libdir}/pkgconfig/ldacBT-enc.pc
%{_libdir}/libldacBT_abr.so
%{_libdir}/libldacBT_enc.so
2. Summary: could be more informative, e.g. "A lossy audio codec for Bluetooth
connections".
3. I'd also recommend using BR: cmake3 and %{cmake3} macro in %build to make it
build seamlessly on EPEL as well.
--- libldac.spec.orig 2019-01-30 17:40:13.000000000 +0100
+++ libldac.spec 2019-02-07 19:03:01.479784500 +0100
@@ -10,7 +10,7 @@
URL:
https://github.com/EHfive/ldacBT
Source0:
%{url}/releases/download/v%{version}/%{archivename}-%{version}.tar.gz
-BuildRequires: cmake
+BuildRequires: cmake3
BuildRequires: gcc
%package devel
@@ -30,7 +30,7 @@
%autosetup -n %{archivename}
%build
-%{cmake} \
+%{cmake3} \
-DLDAC_SOFT_FLOAT=OFF \
-DINSTALL_LIBDIR=%{_libdir} \
./
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component