[Bug 536684] New: Review Request: eclipse-mdt-ocl - Implementation of the OCL OMG metamodel for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: eclipse-mdt-ocl - Implementation of the OCL OMG metamodel for Eclipse
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Summary: Review Request: eclipse-mdt-ocl - Implementation of the OCL OMG metamodel for Eclipse Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fedora@matbooth.co.uk QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
This package depends eclipse-mdt-uml2, whose review request is bug #536683.
Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl-1.3.0-1.fc12.src.rpm
Description: OCL is an implementation of the Object Constraint Language (OCL) OMG standard for EMF-based models. The OCL component provides the following capabilities to support OCL integration:
* Defines APIs for parsing and evaluating OCL constraints and queries on EMF models. * Defines an Ecore implementation of the OCL abstract syntax model, including support for serialization of parsed OCL expressions. * Provides a Visitor API for analyzing/transforming the AST model of OCL expressions. * Provides an extensibility API for clients to customize the parsing and evaluation environments used by the parser.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |536683
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|536683 | Depends on| |536683
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |537452
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |537451
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |537652
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@v3.sk AssignedTo|nobody@fedoraproject.org |lkundrak@v3.sk Flag| |fedora-review?
--- Comment #1 from Lubomir Rintel lkundrak@v3.sk 2009-11-21 14:09:59 EDT --- * Package name and version are in accordance with packaging guidelines * SPEC file clean, legible and well-commented * License tag correct, license packaged as %doc * Local mockbuild with eclipse-mdt-uml2 dragged in succeeded * RPMLint happy * a couple of warnings spelling errors in fc13, all of them false positives * warning about symlink target not being in package; ok since it's in dependnecy * Filelist okay * Provides/Require list ok
Objections:
1.) Why do you check stuff out from CVS and make up a qualifier? There seem to be a source bundle available at the downloads page: http://www.eclipse.org/modeling/mdt/downloads/?project=ocl
2.) Please don't pretty-format the Description. It does not always look well in package management front-ends.
3.) Please use build-classpath to get the file name of lpgjavaruntime.jar. Like: ln -s ../../../../../../../$(build-classpath lpgjavaruntime) \ net.sourceforge.lpg.lpgjavaruntime_1.1.0.jar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
--- Comment #2 from Mat Booth fedora@matbooth.co.uk 2009-11-22 09:11:23 EDT --- (In reply to comment #1)
- Package name and version are in accordance with packaging guidelines
- SPEC file clean, legible and well-commented
- License tag correct, license packaged as %doc
- Local mockbuild with eclipse-mdt-uml2 dragged in succeeded
- RPMLint happy
- a couple of warnings spelling errors in fc13, all of them false positives
- warning about symlink target not being in package; ok since it's in
dependnecy
- Filelist okay
- Provides/Require list ok
Objections:
1.) Why do you check stuff out from CVS and make up a qualifier? There seem to be a source bundle available at the downloads page: http://www.eclipse.org/modeling/mdt/downloads/?project=ocl
See the eclipse-mdt-uml2 review. The qualifier comes from the release tag we use to check the source out of version control - see get-mdt-ocl.sh.
2.) Please don't pretty-format the Description. It does not always look well in package management front-ends.
Ok, no probs.
3.) Please use build-classpath to get the file name of lpgjavaruntime.jar. Like: ln -s ../../../../../../../$(build-classpath lpgjavaruntime) \ net.sourceforge.lpg.lpgjavaruntime_1.1.0.jar
Ok, sure.
Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl-1.3.0-2.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Bug 536684 depends on bug 536683, which changed state.
Bug 536683 Summary: Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse https://bugzilla.redhat.com/show_bug.cgi?id=536683
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Lubomir Rintel lkundrak@v3.sk 2009-11-27 07:14:19 EDT --- Looks well now.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Mat Booth fedora@matbooth.co.uk 2009-11-27 09:05:05 EDT --- (In reply to comment #3)
Looks well now.
APPROVED
Nice one, thanks.
New Package CVS Request ======================= Package Name: eclipse-mdt-ocl Short Description: Implementation of the OCL OMG metamodel for Eclipse Owners: mbooth Branches: F-12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Jason Tibbitts tibbs@math.uh.edu 2009-12-01 13:45:37 EDT --- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=536684
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #6 from Mat Booth fedora@matbooth.co.uk 2009-12-01 15:16:38 EDT --- Built successfully for rawhide, closing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla