https://bugzilla.redhat.com/show_bug.cgi?id=1646579
Bug ID: 1646579 Summary: Review Request: perl-Net-IMAP-Client - IMAP client library for Perl Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: lkundrak@v3.sk QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
SPEC: http://v3.sk/~lkundrak/SPECS/perl-Net-IMAP-Client.spec SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Net-IMAP-Client-0.9505-1.fc29.src.rpm
Description:
Net::IMAP::Client provides methods to access an IMAP server. It aims to provide a simple and clean API, while employing a rigorous parser for IMAP responses in order to create Perl data structures from them. The code is simple, clean and extensible.
https://bugzilla.redhat.com/show_bug.cgi?id=1646579
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1646582
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1646582 [Bug 1646582] Review Request: lumail - Modern console-based e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1646579
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- URL and Source addresses are Ok. Source archive (SHA-256: d3f6a608b85e09a8080a67a9933837aae6f2cd0e8ee39df3380123dc5e3de912) is original. Ok. Summary verified from lib/Net/IMAP/Client.pm. Ok. Description verified from lib/Net/IMAP/Client.pm. Ok. License verified from lib/Net/IMAP/Client.pm and README. Ok. No XS code, noarch BuildArch is Ok.
All tests pass. Ok.
$ rpmlint perl-Net-IMAP-Client-0.9505-1.fc30.src.rpm review-perl-Net-IMAP-Client/results/perl-Net-IMAP-Client-0.9505-1.fc30.noarch.rpm review-perl-Net-IMAP-Client/results/perl-Net-IMAP-Client-0.9505-1.fc30.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpm -q -lv -p perl-Net-IMAP-Client-0.9505-1.fc30.noarch.rpm drwxr-xr-x 2 root root 0 nov. 8 11:51 /usr/share/doc/perl-Net-IMAP-Client -rw-r--r-- 1 root root 3681 janv. 18 2014 /usr/share/doc/perl-Net-IMAP-Client/Changes -rw-r--r-- 1 root root 1104 juil. 18 2014 /usr/share/doc/perl-Net-IMAP-Client/META.json -rw-r--r-- 1 root root 910 déc. 3 2008 /usr/share/doc/perl-Net-IMAP-Client/README -r--r--r-- 1 root root 12636 nov. 8 11:51 /usr/share/man/man3/Net::IMAP::Client.3pm.gz -r--r--r-- 1 root root 2435 nov. 8 11:51 /usr/share/man/man3/Net::IMAP::Client::MsgAddress.3pm.gz -r--r--r-- 1 root root 5001 nov. 8 11:51 /usr/share/man/man3/Net::IMAP::Client::MsgSummary.3pm.gz drwxr-xr-x 2 root root 0 nov. 8 11:51 /usr/share/perl5/vendor_perl/Net drwxr-xr-x 2 root root 0 nov. 8 11:51 /usr/share/perl5/vendor_perl/Net/IMAP drwxr-xr-x 2 root root 0 nov. 8 11:51 /usr/share/perl5/vendor_perl/Net/IMAP/Client -r--r--r-- 1 root root 60101 juil. 18 2014 /usr/share/perl5/vendor_perl/Net/IMAP/Client.pm -r--r--r-- 1 root root 3454 déc. 3 2008 /usr/share/perl5/vendor_perl/Net/IMAP/Client/MsgAddress.pm -r--r--r-- 1 root root 15241 déc. 21 2010 /usr/share/perl5/vendor_perl/Net/IMAP/Client/MsgSummary.pm File permissions and layout are Ok.
$ rpm -q --requires -p perl-Net-IMAP-Client-0.9505-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.0) 1 perl(bytes) 1 perl(Encode) 1 perl(IO::Socket::INET) 1 perl(IO::Socket::SSL) 1 perl(List::MoreUtils) 1 perl(List::Util) 1 perl(Net::IMAP::Client::MsgAddress) 1 perl(Net::IMAP::Client::MsgSummary) 1 perl(overload) 1 perl(Socket) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
⇒ Add BR for vars, strict, warnings, Socket, overload.
$ rpm -q --provides -p perl-Net-IMAP-Client-0.9505-1.fc30.noarch.rpm perl(Net::IMAP::Client) = 0.9505 perl(Net::IMAP::Client::MsgAddress) perl(Net::IMAP::Client::MsgSummary) perl-Net-IMAP-Client = 0.9505-1.fc30 Binary provides are Ok.
Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=30735927). Ok
The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package approved. Please fix the aforementioned issue before import.
https://bugzilla.redhat.com/show_bug.cgi?id=1646579
--- Comment #2 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Net-IMAP-Client
https://bugzilla.redhat.com/show_bug.cgi?id=1646579
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2018-11-14 12:55:18
--- Comment #3 from Lubomir Rintel lkundrak@v3.sk --- Imported and built (with the missing BRs added).
Thank you!
package-review@lists.fedoraproject.org