https://bugzilla.redhat.com/show_bug.cgi?id=2248960
Bug ID: 2248960 Summary: Review Request: gstreamer1-plugin-openh264 - GStreamer OpenH264 plugin Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: klember@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://kalev.fedorapeople.org/gstreamer1-plugin-openh264.spec SRPM URL: https://kalev.fedorapeople.org/gstreamer1-plugin-openh264-1.22.5-1.fc40.src.... Description: GStreamer is a streaming media framework, based on graphs of elements which operate on media data.
This package contains the OpenH264 plugin.
Fedora Account System Username: kalev
This splits out gstreamer1-plugin-openh264 from openh264 spec file where it was previously built from a single srpm together with the openh264 library (see https://src.fedoraproject.org/rpms/openh264/blob/rawhide/f/openh264.spec). The plan is to link it against the new "noopenh264" stub which we are able to ship in Fedora proper, see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2247274 which then gets swapped out with the actual openh264 library package (downloaded from Cisco servers) during first 'dnf update'.
Note that I suspect this package is going to be short lived in Fedora because we'll probably just end up enabling the openh264 plugin in gstreamer1-plugins-bad-free and retiring separate gstreamer1-plugin-openh264 package. There is some value in a new package during transition period but I expect it to be short lived.
The separate gstreamer1-plugin-openh264 package is however going to be needed for EPEL 9 so that we can drop the gstreamer plugin from the openh264 srpm (and Cisco repo) and instead ship the plugin in EPEL proper. So this is mostly a new EPEL package review request, but I'd like to use it in Fedora as well during the transition period.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=108818423
Scratch builds are done using 'fedpkg build --scratch --srpm --target f40-build-side-77098' - noopenh264 cannot be merged into rawhide before we have been able to get an openh264 version that obsoletes noopenh264 in place in the Cisco repo, so all builds have to be done using the side tag for now.
https://bugzilla.redhat.com/show_bug.cgi?id=2248960
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://www.openh264.org/
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6617270 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2248960
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com CC| |ngompa13@gmail.com Status|NEW |POST Flags| |fedora-review+
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2248960
Yaakov Selkowitz yselkowi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yselkowi@redhat.com
--- Comment #3 from Yaakov Selkowitz yselkowi@redhat.com --- Please DO NOT import this into Fedora branches, but it makes sense for EPEL.
https://bugzilla.redhat.com/show_bug.cgi?id=2248960
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/gstreamer1-plugin-openh264
https://bugzilla.redhat.com/show_bug.cgi?id=2248960
--- Comment #5 from Kalev Lember klember@redhat.com --- Thanks for the super quick review, Neal!
https://bugzilla.redhat.com/show_bug.cgi?id=2248960
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |WONTFIX Last Closed| |2025-01-21 19:41:16
--- Comment #7 from Kalev Lember klember@redhat.com --- Let's drop this package as we ended up adding gstreamer1-plugin-openh264 as a subpackage of gstreamer1-plugins-bad-free instead.
Product: Fedora Version: rawhide Component: Package Review
Kalev Lember klember@redhat.com has canceled Package Review package-review@lists.fedoraproject.org's request for Kalev Lember klember@redhat.com's needinfo: Bug 2248960: Review Request: gstreamer1-plugin-openh264 - GStreamer OpenH264 plugin https://bugzilla.redhat.com/show_bug.cgi?id=2248960
https://bugzilla.redhat.com/show_bug.cgi?id=2248960
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(klember@redhat.co | |m) |
package-review@lists.fedoraproject.org