Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
Summary: Review Request: nautilus-python - Python bindings for Nautilus Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: trond.danielsen@fedoraproject.org QAContact: fedora-package-review@redhat.com
Spec URL: ftp://open-gnss.org/pub/fedora/nautilus-python/nautilus-python.spec SRPM URL: ftp://open-gnss.org/pub/fedora/nautilus-python/nautilus-python-0.4.3-1.src.rpm Description: Python bindings for Nautilus.
- Builds in mock on rawhide i386 and fc6 x86_64. - Output from rpmlint: [trondd@localhost i386]$ rpmlint nautilus-python-* W: nautilus-python-devel no-documentation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-python - Python bindings for Nautilus
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
trond.danielsen@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |235191 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-python - Python bindings for Nautilus
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
jspaleta@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |jspaleta@gmail.com Flag| |fedora-review?
------- Additional Comments From jspaleta@gmail.com 2007-04-20 04:15 EST ------- The Good + naming is good + specfile name matches base package name + Licensed as GPL and includes COPYING file accordingly + specfile written in english-ese and is legible + included source md5sum checks with upstream source as listed in SOURCE0 url f4bd5de3a9e01c80fc0a2ef7aeb64dd7 nautilus-python-0.4.3.tar.gz + builds on x86 fedora-development in mock + buildrequires look good + no locales + not relocatable + base package owns all directories it creates and directory ownership of parent directories is accounted for in package deps + permissions seem to be okay + clean section is okay + consistent use of macros + permissible code and content + items in doc are not runtime necessary + devel requires versioned base package + not a gui + does not obviously own files from another package + install section looks good + build.log shows its using the RPM_OPT_FLAGS
The Bad - Must remove all .la files - devel subpackage needs to require pkgconfig due to directory ownership rules - Need to include appropriate ldconfig scriptlets for shared libraries
The Suggestions ? Would it be better if the examples were placed in docs section of the devel package, instead of in the main package?
The Corrections Attached you'll find an updated spec file that corrects the blocker items listed above. Please review it write back if you need to discuss anything. Once you resubmit updated spec and srpm urls that correct the blockers this should be approvable.
-jef
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-python - Python bindings for Nautilus
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
------- Additional Comments From jspaleta@gmail.com 2007-04-20 04:17 EST ------- Created an attachment (id=153113) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=153113&action=vie...) updated spec with review corrections included
specfile with suggested review blocker corrections included.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-python - Python bindings for Nautilus
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
------- Additional Comments From trond.danielsen@gmail.com 2007-04-21 05:07 EST ------- (In reply to comment #1)
The Suggestions ? Would it be better if the examples were placed in docs section of the devel package, instead of in the main package?
That is a good idea. I have added it to the spec file.
The Corrections Attached you'll find an updated spec file that corrects the blocker items listed above. Please review it write back if you need to discuss anything. Once you resubmit updated spec and srpm urls that correct the blockers this should be approvable.
New versions of the source rpm and spec file can be found here: ftp://open-gnss.org/pub/fedora/nautilus-python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-python - Python bindings for Nautilus
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
jspaleta@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From jspaleta@gmail.com 2007-04-22 16:19 EST ------- nautilus-python-0.4.3-3.fc7.src.rpm APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-python - Python bindings for Nautilus
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
trond.danielsen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From trond.danielsen@gmail.com 2007-04-22 17:07 EST ------- New Package CVS Request ======================= Package Name: nautilus-python Short Description: Python bindings for Nautilus. Owners: trond.danielsen@gmail.com Branches: FC-6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-python - Python bindings for Nautilus
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-python - Python bindings for Nautilus
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
trond.danielsen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From trond.danielsen@gmail.com 2007-04-24 16:44 EST ------- Thank you for the review and the feedback!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-python - Python bindings for Nautilus
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235189
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235189
Caghan Demirci caghand@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |caghand@gmail.com Flag| |needinfo?
--- Comment #7 from Caghan Demirci caghand@gmail.com 2011-12-16 09:46:07 EST --- Package Change Request ====================== Package Name: nautilus-python New Branches: el5 el6 Owners: dignan InitialCC: jkeating
dignan is already listed as the owner of the EPEL package under https://admin.fedoraproject.org/pkgdb/acls/name/nautilus-python. However, the package can still not be found in the EPEL repository. I imagine that a branch request is necessary. Note that versions higher than 0.7.0-3 will not work on RHEL because they require Nautilus 3.
I am not able to set the fedora-cvs flag to ?, as recommended in the instructions. It is locked at +. So I set the needinfo flag to ?.
Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235189
Ignacio Vazquez-Abrams ivazqueznet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ivazqueznet@gmail.com Flag|needinfo?, fedora-cvs+ |fedora-cvs?
--- Comment #8 from Ignacio Vazquez-Abrams ivazqueznet@gmail.com 2012-02-07 21:31:16 EST --- I've set the flag to ? so that we can get this done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235189
--- Comment #9 from Jon Ciesla limburgher@gmail.com 2012-02-08 08:09:33 EST --- I don't see anything in pkgdb or git that doesn't match what's requested.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235189
--- Comment #10 from Ignacio Vazquez-Abrams ivazqueznet@gmail.com 2012-02-08 08:13:40 EST --- Fair enough. I'm just used to seeing some sort of confirmation that the actions had been performed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235189
Caghan Demirci caghand@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review+ |fedora-review?, needinfo?
--- Comment #11 from Caghan Demirci caghand@gmail.com 2012-02-08 17:49:57 EST ---
Hi Jon and Ignacio,
pkgdb is just fine. I never said that pkgdb was missing something. But the package itself can still not be found in the EPEL repository. See RepoView, for example: http://dl.fedoraproject.org/pub/epel/6/SRPMS/repoview/letter_n.group.html There is no "nautilus-python" in there.
Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235189
Caghan Demirci caghand@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo? |
--- Comment #12 from Caghan Demirci caghand@gmail.com 2012-04-05 16:40:51 EDT ---
nautilus-python will be built for EPEL within the context of bug 771262.
There is nothing more to do here.
package-review@lists.fedoraproject.org