https://bugzilla.redhat.com/show_bug.cgi?id=2314453
Bug ID: 2314453 Summary: Review Request: rust-qcow2-rs - Rust library for read/write qcow2 image in async/await Product: Fedora Version: rawhide Hardware: All URL: https://crates.io/crates/futures-locks OS: Linux Status: NEW Component: Package Review Keywords: AutomationTriaged Severity: medium Assignee: nobody@fedoraproject.org Reporter: minlei@redhat.com QA Contact: extras-qa@fedoraproject.org CC: amulhern@redhat.com, bgurney@redhat.com, decathorpe@gmail.com, extras-qa@fedoraproject.org, package-review@lists.fedoraproject.org, rjones@redhat.com Depends On: 2305524 Target Milestone: --- Classification: Fedora
Spec URL: https://people.redhat.com/minlei/fedpkg/qcow2-rs/rust-qcow2-rs.spec
SRPM URL: https://people.redhat.com/minlei/fedpkg/qcow2-rs/rust-qcow2-rs-0.1.6-1.fc42....
Description:
Rust library for read/write qcow2 image in async/await, and provids block like read/write interface.
Fedora Account System Username: minlei2 Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=123898934
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2305524 [Bug 2305524] Review Request: rust-futures-locks - Futures-aware lock primitives
https://bugzilla.redhat.com/show_bug.cgi?id=2314453
Ming Lei minlei@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|unspecified |medium Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2314453
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? | Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- The `fedora-review` flag is set by the *reviewer*, not the *submitter*.
https://bugzilla.redhat.com/show_bug.cgi?id=2314453
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2314453
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8066290 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2314453
--- Comment #3 from Ming Lei minlei@redhat.com ---
Hello Guys,
Gentle ping...
thanks,
https://bugzilla.redhat.com/show_bug.cgi?id=2314453
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- It looks like this package depends on a crate that was so old and unused in Fedora that I cleaned it up two days ago: https://src.fedoraproject.org/rpms/rust-crypto-hash
Problem: nothing provides requested (crate(crypto-hash/default) >= 0.3.0 with crate(crypto-hash/default) < 0.4.0~)
I try to avoid removing packages that are needed by packages that are pending review, but I obviously missed this one. Sorry! I'll get it added back soon.
https://bugzilla.redhat.com/show_bug.cgi?id=2314453
--- Comment #5 from Ming Lei minlei@redhat.com --- Hi Fabio,
I saw rust-crypto-hash-0.3.4 is in rawhide, so can we move on with this BZ?
Thanks,
https://bugzilla.redhat.com/show_bug.cgi?id=2314453
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Yes, sorry about the delay. The package looks good, just one question:
Is the rqcow2 executable useful and you explicitly want to ship it with the package, or do you only need the qcow2-rs crate for its library interface? If you do not need rcow2 executable, excluding it would make the package quite a bit simpler to maintain.
https://bugzilla.redhat.com/show_bug.cgi?id=2314453
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(minlei@redhat.com | |)
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Are you still interested in this package? If yes, please answer the question in my last comment and adjust the packaging, if you don't need the rqcow2 executable.
You could make use of a rust2rpm.toml config file with these contents if you want to make this change:
""" [package] cargo-install-bin = false """
package-review@lists.fedoraproject.org