https://bugzilla.redhat.com/show_bug.cgi?id=1945159
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
Flags| |fedora-review+
--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
+ package name is OK
+ license is acceptable (a mix, as discussed above)
? license is specified correctly:
Not sure about this one. As mentioned above, I strongly suspect it can be
simplified.
Over-specifying the license is not a very big issue… If it's the last issue
remaining,
I think we can proceed with the package, and maybe fix that later.
+ builds and installs correctly
+ fedora-review doesn't find any issues
+ R/P/BR look correct
Specifying all the versions of the bundled provides is the righteous thing to
do, and
what the guidelines recommend. Nevertheless, with some many items, keeping
this updated
is going to be chore. Additional motivation to unbundle ;)
rpmlint:
rizin.src:120: W: setup-not-quiet
Oh, you need -q so that a list of files is not printed. Seems reasonable to add
that.
rizin.x86_64: W: shared-lib-calls-exit /usr/lib64/librz_core.so.0.1.2
exit(a)GLIBC_2.2.5
rizin.x86_64: W: shared-lib-calls-exit /usr/lib64/librz_crypto.so.0.1.2
exit(a)GLIBC_2.2.5
rizin.x86_64: W: shared-lib-calls-exit /usr/lib64/librz_egg.so.0.1.2
exit(a)GLIBC_2.2.5
rizin.x86_64: W: shared-lib-calls-exit /usr/lib64/librz_main.so.0.1.2
exit(a)GLIBC_2.2.5
rizin.x86_64: W: shared-lib-calls-exit /usr/lib64/librz_socket.so.0.1.2
exit(a)GLIBC_2.2.5
Libraries should not called exit… Unless it's a false positive, seems like an
upstream bug.
rizin.x86_64: W: no-manual-page-for-binary rz-sign
rizin-common.noarch: W: no-documentation
rizin-devel.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 10 warnings.
In -devel, files are under /usr/include/librz/. And in general, everything is
either in private directories
or namespaced under "rz_" / "rz-" / "librz_", so there
should be no conflicts.
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component