https://bugzilla.redhat.com/show_bug.cgi?id=1750045
--- Comment #2 from Danishka Navin <danishka(a)gmail.com> ---
Robert, Thanks for taking this package to review.
(In reply to Robert-André Mauchin from comment #1)
- Not a valid license shourthand, it should be "OFL":
License: SIL Open Font License
Ok, I will make it as OFL
- Use a better name for your archive:
Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
- What is this:
%undefine _disable_source_fetch
without this rpmbuild looking for the source file in my local.
danishka@localhost rpmbuild]$ rpmbuild -ba SPECS/abhaya-libre-fonts.spec
error: Bad source:
/home/danishka/rpmbuild/SOURCES/abhaya-libre-fonts-1.060.tar.gz: No such file
or directory
When I add it source is downloading from the given location.
[danishka@localhost rpmbuild]$ rpmbuild -ba SPECS/abhaya-libre-fonts.spec
warning: Downloading
https://github.com/mooniak/abhaya-libre-font/archive/v1.060/abhaya-libre-...
to /home/danishka/rpmbuild/SOURCES/abhaya-libre-fonts-1.060.tar.gz
- Use %autosetup
%setup -q -c
then:
install -m 0644 -p fonts/ttf/AbhayaLibre-Bold.ttf %{buildroot}%{_fontdir}
install -m 0644 -p fonts/ttf/AbhayaLibre-ExtraBold.ttf
%{buildroot}%{_fontdir}
install -m 0644 -p fonts/ttf/AbhayaLibre-Medium.ttf %{buildroot}%{_fontdir}
install -m 0644 -p fonts/ttf/AbhayaLibre-Regular.ttf %{buildroot}%{_fontdir}
install -m 0644 -p fonts/ttf/AbhayaLibre-SemiBold.ttf %{buildroot}%{_fontdir}
- Don't:
install -m 0755 -d %{buildroot}/usr/share/doc/%{fontname}
install -m 0644 -p abhaya-libre-font-1.060/CONTRIBUTORS.md
%{buildroot}/usr/share/doc/%{fontname}
install -m 0644 -p abhaya-libre-font-1.060/README.md
%{buildroot}/usr/share/doc/%{fontname}
install -m 0644 -p abhaya-libre-font-1.060/OFL.txt
%{buildroot}/usr/share/doc/%{fontname}
install -m 0644 -p abhaya-libre-font-1.060/FONTLOG.md
%{buildroot}/usr/share/doc/%{fontname}
The license file must be installed with %license in %files:
%license OFL.txt
The docs should be installed with %doc in %files:
%doc CONTRIBUTORS.md README.md FONTLOG.md
- Release should start at 1 in Fedora not 0:
Release: 0%{?dist}
noted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component