https://bugzilla.redhat.com/show_bug.cgi?id=1013039
Bug ID: 1013039 Summary: Review Request: java-diff-utils - diff utils for Java Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: willb@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://freevariable.com/java-diff-utils/java-diff-utils.spec SRPM URL: http://freevariable.com/java-diff-utils/java-diff-utils-1.3.0-1.fc19.src.rpm Description: The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java. Fedora Account System Username: willb
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
Will Benton willb@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1010003 (bigdata-review)
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@libero.it
--- Comment #1 from gil cattaneo puntogil@libero.it --- hi there are some changes todo: License ASL 2.0 If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD (read MUST) query upstream to include it. Name should be 'diffutils' as the aId of the pom file
Group are unnecessary (required only for EPEL) If the source oackage provides artifacs <= 2 then you can use %mvn_file com.googlecode.java-diff-utils:diffutils diffutils OR %mvn_file :diffutils diffutils OR %mvn_file : diffutils this in install the artifact in %{_javadir} instead of %{_javadir}/%{name} regards
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |puntogil@libero.it Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
--- Comment #2 from gil cattaneo puntogil@libero.it --- (In reply to gil cattaneo from comment #1)
Name should be 'diffutils' as the aId of the pom file
sorry forgot 'diffutils' pkg is already present in Fedora repo... leave java-diff-utils or use java-diffutils
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
--- Comment #3 from gil cattaneo puntogil@libero.it --- i would like to take this review
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
--- Comment #4 from Will Benton willb@redhat.com --- Spec URL: http://freevariable.com/java-diff-utils/java-diffutils.spec SRPM URL: http://freevariable.com/java-diff-utils/java-diffutils-1.3.0-2.fc19.src.rpm Description: The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java. Fedora Account System Username: willb
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |java-diff-utils - diff |java-diffutils - diff utils |utils for Java |for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
--- Comment #5 from gil cattaneo puntogil@libero.it --- Created attachment 804113 --> https://bugzilla.redhat.com/attachment.cgi?id=804113&action=edit review notes
not approved
[!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 16 files have unknown license. Detailed output of licensecheck in /home/gil/1013039-java- diffutils/licensecheck.txt ASL 1.1: src/main/java/difflib/myers/DiffException.java src/main/java/difflib/myers/MyersDiff.java src/main/java/difflib/myers/PathNode.java src/main/java/difflib/myers/Snake.java [!]: Package contains no bundled libraries without FPC exception. also available in http://www.docjar.com/jar_detail/org.apache.commons.jrcs.diff.jar.html
[!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[!]: Package does not include license text files separate from upstream.
java-diffutils.noarch: W: summary-ended-with-dot C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java. java-diffutils.noarch: E: summary-too-long C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java. java-diffutils.src: W: summary-ended-with-dot C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java. java-diffutils.src: E: summary-too-long C The DiffUtils library for computing diffs, applying patches, generating side-by-side view in Java. java-diffutils.src:8: W: macro-in-comment %{version} java-diffutils.src:8: W: macro-in-comment %{name} java-diffutils.src:8: W: macro-in-comment %{version} java-diffutils.src:8: W: macro-in-comment %{name} java-diffutils.src:8: W: macro-in-comment %{version} java-diffutils.src:8: W: macro-in-comment %{name} java-diffutils.src:8: W: macro-in-comment %{version} java-diffutils.src: W: invalid-url Source0: java-diffutils-1.3.0.tar.gz
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
--- Comment #6 from gil cattaneo puntogil@libero.it --- please, report a bug @ http://code.google.com/p/java-diff-utils/issues/ for "source package does not include license text(s)"
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
Will Benton willb@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org |
--- Comment #7 from Will Benton willb@redhat.com --- (In reply to gil cattaneo from comment #6)
please, report a bug @ http://code.google.com/p/java-diff-utils/issues/ for "source package does not include license text(s)"
http://code.google.com/p/java-diff-utils/issues/detail?id=32
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|puntogil@libero.it |nobody@fedoraproject.org Flags|fedora-review+ |
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |puntogil@libero.it
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1013039
Oliver Kopp kopp.dev@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kopp.dev@gmail.com
--- Comment #14 from Oliver Kopp kopp.dev@gmail.com --- I contacted the main authors of JRCS and java-diff-utils. We agreed to change the licence of the whole code to Apache-1.1.
jrcs: https://bitbucket.org/apalala/jrcs/src
java-diff-utils (moved from Google Code to GitHub) --> https://github.com/dnaumenko/java-diff-utils
I'm trying to maintain a more recent version at https://github.com/java-diff-utils/java-diff-utils.
There is another fork (from Google Code) at https://github.com/java-diff-utils/java-diff-utils-wumpz. That fork, however, still uses the wrong license statement. I am trying to get in touch with the author.
package-review@lists.fedoraproject.org