https://bugzilla.redhat.com/show_bug.cgi?id=1767918
--- Comment #5 from Tony Asleson <tasleson(a)redhat.com> ---
(In reply to Elliott Sales de Andrade from comment #4)
Please link the spec *and* srpm directly (no .1 suffixes), or
fedora-review
does not work.
Sorry about that, existing spec file updated:
https://tasleson.fedorapeople.org/targetd/targetd.spec
Done
Done
It doesn't look like you run systemd in scriptlets, so you
don't need to
Require it.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/
#_dependencies_on_the_systemd_package
Done
Thanks!
diff --git a/targetd.spec b/targetd.spec
index ccd3f62..912a697 100644
--- a/targetd.spec
+++ b/targetd.spec
@@ -11,10 +11,6 @@ BuildRequires: systemd-rpm-macros
BuildRequires: python3-devel
Requires: python3-PyYAML python3-setproctitle python3-rtslib
target-restore
Requires: nfs-utils, btrfs-progs, python3-blockdev, libblockdev-lvm
-Requires(post): systemd
-Requires(preun): systemd
-Requires(postun): systemd
-
%description
targetd turns the machine into a remotely-configurable storage appliance.
@@ -26,7 +22,7 @@ those volumes over iSCSI.
%setup -q
%build
-%{__python3} setup.py build
+%py3_build
%install
mkdir -p %{buildroot}%{_mandir}/man8/
@@ -35,7 +31,7 @@ mkdir -p %{buildroot}%{_sysconfdir}/target/
install -m 644 %{SOURCE1} %{buildroot}%{_unitdir}/targetd.service
install -m 644 targetd.yaml %{buildroot}%{_sysconfdir}/target/targetd.yaml
install -m 644 targetd.8 %{buildroot}%{_mandir}/man8/
-%{__python3} setup.py install --skip-build --root %{buildroot}
+%py3_install
%post
%systemd_post targetd.service
@@ -53,7 +49,7 @@ install -m 644 targetd.8 %{buildroot}%{_mandir}/man8/
%{python3_sitelib}/*.egg-info
%license LICENSE
%doc README.md API.md client
-%{_mandir}/man8/targetd.8.gz
+%{_mandir}/man8/targetd.8*
%config(noreplace) %{_sysconfdir}/target/targetd.yaml
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component