https://bugzilla.redhat.com/show_bug.cgi?id=1668010
--- Comment #12 from Tom Stellard <tstellar(a)redhat.com> ---
Spec URL:
https://fedorapeople.org/~tstellar/hip.spec
SRPM URL:
https://fedorapeople.org/~tstellar/hip-1.5.18494-1.rocm2.0.0.fc31.src.rpm
Added bundled(clara)
(In reply to Felix Schwarz from comment #10)
-> License: MIT and Boost
Fixed.
Also
https://docs.fedoraproject.org/en-US/packaging-guidelines/
LicensingGuidelines/#_multiple_licensing_scenarios says:
> In addition, the package must contain a comment explaining the multiple licensing
breakdown.
Only pstream.h uses the boost license and only "lpl" includes it so it
should be easy to document in "%files" that lpl is under "MIT AND
Boot".
Added a comment for this.
Requires: bintuils
Typo: "binutils"
Fixed this.
Unless I made a mistake (using F30 with a custom recompile of the rawhide
SRPMs) I think you also must depend on "rocm-runtime-devel".
I split hip into hip-runtime and hip-runtime-devel packages like I did with
hcc, so hip no requires hip-runtime-devel which requires rocm-runtimed-devel.
My biggest gripe is how to deal with "libhip_hcc_static.a" properly
(
https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-
libraries). A -devel package does not make much sense for hip and as far as
I can see upstream does not provide a way to prevent static linking with
hipcc.
I've deleted the static library.
(In reply to Robert-André Mauchin from comment #11)
-DHCC_HOME=/usr/ \
-DHSA_PATH=/usr/ \
Use %{_prefix} here
This has been fixed.
- You need to put the include, cmake files, and unversioned library into a
devel subpackage. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
I've added a hip-runtime-devel sub-package and moved the mentioned files there.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component