https://bugzilla.redhat.com/show_bug.cgi?id=2005318
mkulik(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #10 from mkulik(a)redhat.com ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Notes:
=======
- bconds work as expected
- No rpmlint issues
- testing functionality on fedora/rhel8
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License v3.0 or
later", "FSF All Permissive License", "GNU General Public
License,
Version 2", "GNU General Public License, Version 3", "GNU
General
Public License v3.0 or later [generated file]", "FSF Unlimited License
(with License Retention) [generated file]", "FSF Unlimited License
[generated file]", "GNU General Public License v2.0 or later",
"X11
License [generated file]", "GNU General Public License v2.0 or later
[generated file]", "GNU Free Documentation License v1.3 or later",
"GNU Free Documentation License v1.3", "FSF Unlimited License (with
License Retention)", "*No copyright* [generated file]",
"[generated
file]". 28 files have unknown license. Detailed output of licensecheck
in /home/mkulik/2005318-autoconf27/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/autoconf(autoconf), /usr/share/autoconf/Autom4te(autoconf),
/usr/share/autoconf/autoconf(autoconf),
/usr/share/autoconf/autoscan(autoconf),
/usr/share/autoconf/autotest(autoconf), /usr/share/autoconf/build-
aux(autoconf), /usr/share/autoconf/m4sugar(autoconf),
/usr/share/emacs/site-lisp/autoconf(autoconf), /usr/share/emacs/site-
lisp/site-start.d(emacs-spice-mode, emacs-common, lilypond, emacs-
filesystem, emacs-irsim-mode, emacs-slime, gforth, autoconf)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 174080 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
echo $version)) missing?
===== SHOULD items =====
Generic:
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Source checksums
----------------
https://ftp.gnu.org/gnu/autoconf/autoconf-2.71.tar.xz :
CHECKSUM(SHA256) this package :
f14c83cfebcc9427f2c3cea7258bd90df972d92eb26752da4ddad81c87a0faa4
CHECKSUM(SHA256) upstream package :
f14c83cfebcc9427f2c3cea7258bd90df972d92eb26752da4ddad81c87a0faa4
Requires
--------
autoconf27 (rpmlib, GLIBC filtered):
/usr/bin/perl
/usr/bin/sh
emacs-filesystem
m4
perl(:VERSION)
perl(Carp)
perl(Class::Struct)
perl(Cwd)
perl(Data::Dumper)
perl(Errno)
perl(Exporter)
perl(File::Basename)
perl(File::Compare)
perl(File::Copy)
perl(File::Find)
perl(File::Spec)
perl(File::Temp)
perl(File::stat)
perl(Getopt::Long)
perl(IO::File)
perl(POSIX)
perl(Text::ParseWords)
perl(constant)
perl(strict)
perl(warnings)
perl-interpreter
Provides
--------
autoconf27:
autoconf27
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -n autoconf27
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Perl, Shell-api
Disabled plugins: SugarActivity, Java, PHP, Haskell, Ocaml, R, Python, C/C++,
fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2005318