Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740814
Roland Grunberg <rgrunber(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Roland Grunberg <rgrunber(a)redhat.com> 2011-10-04 11:45:59 EDT
---
I was thinking that since the javadoc subpackage is derived from the sources,
it would qualify as an implicit dependency. Everything else looks fine. Setting
as approved.
= REQUIRED ITEMS =
[X] Package meets the Packaging Guidelines[2].
[X] Package does not contain duplicates in %files.
[X] If source tarball includes bundled jar/class files these need to be
removed prior to building
=== Maven ===
[X] If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
=== Other suggestions ===
[X] If possible use upstream build method (maven/ant/javac)
[X] Reviewer should test that the package builds in mock.
Tested on: fedora-rawhide-i386 for mock and fedora-15-i386 for maven build.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.