Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=514602
--- Comment #5 from Miloslav Trmač <mitr(a)redhat.com> 2009-07-30 17:07:57 EDT ---
Thanks for the review.
(In reply to comment #4)
Bad:
- Package contains not a BuildRoot tag.
https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag says it is not
necessary any more.
- Buildroot will not been clean on the start of %clean and %install
Same here -
https://fedoraproject.org/wiki/PackagingGuidelines#Prepping_BuildRoot_For...
for %install.
%clean does clean the buildroot.
- The package description could be more verbose.
As a minimum you should wrote:
this package provide a GUI which allows the user to
configure the linux audit subsystem.
Thanks, fixed.
- Please create a conflict statement agains the audit package
before the splitt off.
AFAICS this should not be necessary -
system-config-audit was a separate
subpackage of audit. There are no file conflicts between the old audit package
and any system-config-audit package, I can't see why the old audit package and
a new system-config-audit package could not coexist.
Updated package:
http://people.redhat.com/mitr/packaging/system-config-audit.spec
http://people.redhat.com/mitr/packaging/system-config-audit-0.4.11-2.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.