https://bugzilla.redhat.com/show_bug.cgi?id=1295115
Dave Johansen <davejohansen(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |davejohansen(a)gmail.com
--- Comment #8 from Dave Johansen <davejohansen(a)gmail.com> ---
Here's my initial feedback:
- Use an ExclusiveArch instead of such a long list of ExcludeArch.
- Use global instead of define (
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_o...
)
- Remove the defintion for _libdir and _lib64dir (should already be defined)
- Is that Requires list really necessary? (
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires )
- Would be nice to get tests working on koji. Do they work in mock? If not,
then I'm guessing that the BuildRequires list is missing something (
https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds )
- Are you hoping to target EL 5? rm/mkdir of %{buildroot} is done
automatically in recent versions of rpmbuild (I believe starting with EL >= 6)
- Setting %attr only required if supporting EL <= 5
- Use the license macro ( compatibility workaround for EPEL can be found at
https://fedoraproject.org/wiki/EPEL:Packaging#The_.25license_tag )
- Use wildcards to reduce list in %files section
- Can the .h and other such files be moved to a -devel package?
- Use Python macros for paths (
https://fedoraproject.org/wiki/Packaging:Python#Macros )
- Use %{_includedir} instead of hardcoded path to /usr/include
- Don't use hard coded path to /usr/share/doc/* (%{_datarootdir} or maybe
%doc)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component