https://bugzilla.redhat.com/show_bug.cgi?id=1664399
--- Comment #4 from Karel Volný <kvolny(a)redhat.com> ---
(In reply to Xavier Bachelot from comment #1)
- Add comments for Source1, Source2 and Patch2 explaining where they
come
from.
if only I knew :-) ... these predate git history, and I had touched the package
only three years _after_ it was imported you-know-where
the manpage seems to be extracted from the Debian package
and the same for the README.method, probably - the only trace I was able to
found is here:
https://github.com/rbrito/pkg-mp3gain/blob/master/debian/README.method
IMHO, we might as well drop the file, as it doesn't convey any important
information about the usage; these things are described on the project's web
...?
- Does the manpage need to be pre-compressed ? The build could handle
the
compression and thus the .gz suffix can be replaced by a wildcard in %files
in case the compression method changes someday.
to be honest, I don't know how this works ... simply copying uncompressed
manpage to workdir in %prep will trigger its compression in %build?
how does rpmbuild know about the manpage file?
- I'd prefer not to touch it if it ain't broke
(In reply to Andrea Musuruane from comment #2)
You can avoid to manually edit the following line for each new
release:
%define tarball_version 1_6_2
...
(In reply to Xavier Bachelot from comment #3)
In any case, you need to either BR: coreutils (for tr) or BR: sed
the package already uses sed so let's stick to it ... and rpmbuild requires it,
so no need to put that into BR(*)
(*) btw, it won't help anyways:
"Because SRPMs are built without the package’s BuildRequires installed"
[
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_rpm_bu...]
I've uploaded the new version with these changes (I don't think we need to
update release and add changelog entries for this WIP):
--- mp3gain.spec~ 2019-01-08 16:47:00.000000000 +0100
+++ mp3gain.spec 2019-01-09 12:18:01.136284939 +0100
@@ -1,14 +1,15 @@
-%define tarball_version 1_6_2
-
Name: mp3gain
Version: 1.6.2
+
+%global tarball_version %(echo %version|%{__sed} 's/\\./_/g')
+
Release: 2%{?dist}
Summary: Lossless MP3 volume adjustment tool
-Group: Applications/Multimedia
License: LGPLv2+
URL:
http://mp3gain.sourceforge.net/
Source0:
https://sourceforge.net/projects/%{name}/files/%{name}/%{version}/%{name}...
+# copied from Debian
Source1: %{name}.1.gz
Source2: README.method
Patch2: %{name}-cflags-1.5.2.patch
@@ -53,7 +54,9 @@
%changelog
* Tue Jan 08 2019 Karel Volný <kvolny(a)redhat.com> - 1.6.2-2
- Import to Fedora (rhbz#1664399)
-- Fixed license tag
+- Fixed License tag
+- Dropped Group tag
+- Improved tarball_version definition
* Wed Jan 02 2019 Sérgio Basto <sergio(a)serjux.com> - 1.6.2-1
- Update to 1.6.2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component