https://bugzilla.redhat.com/show_bug.cgi?id=1877006
--- Comment #2 from Jordi Sanfeliu <jordi(a)fibranet.cat> ---
(In reply to Robert-André Mauchin 🐧 from comment #1)
All these things have been obsolete for years:
# Do a systemd-based build from F-15; otherwise, a sysvinit-based build
%global use_systemd %([ "(" 0%{?fedora} -gt 14 ")" -o "("
0%{?rhel} -gt 6
")" ] && echo 1 || echo 0)
# This macro only defined by default around Fedora 10 time
%{!?_initddir:%global _initddir %{_initrddir}}
# With systemd, the run directory is /run; otherwise it's /var/run
%if %{use_systemd}
%global rundir /run
%else
%global rundir %{_localstatedir}/run
%endif
F15? F10? Older than my nephew. Don't include them.
LOL, sorry. Removed.
- Source must either be an url or you need to add a comment
explaining how
the archive got generated:
Source0: %{name}-%{version}.tar.gz
Hmm ... if I put the line:
Source0:
https://github.com/jcbf/smf-spf/archive/v2.4.3.tar.gz
then I get the following message:
# rpmbuild -ba smf-spf.spec
error: Bad source: /root/rpmbuild/SOURCES/v2.4.3.tar.gz: No such file or
directory
How/where should I include the URL?
- Not needed:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
Group: System Environment/Daemons
rm -rf %{buildroot}
%clean
rm -rf %{buildroot}
%defattr(-,root,root,-)
OK, removed.
- Use the System scriptlets, see:
OK, done.
- COPYING must be installed with %license, not %doc:
OK,
done.
- make %{?_smp_mflags} OPTFLAGS="%{optflags}"
→
%set_build_flags
Sorry, I don't understand this.
- Add the comment regarding the patches above each PatchX line
OK, done.
- Requires(pre): /usr/bin/getent, /usr/sbin/groupadd,
/usr/sbin/useradd,
/usr/sbin/usermod → Requires(pre): shadow-utils
OK, done.
- One BR per line would be nice:
BuildRequires: libspf2-devel >= 1.2.5
BuildRequires: sendmail-milter-devel >= 8.12
OK, done.
%make_build
- Explicitly BR gcc
I don't understand this.
Refreshed files:
Spec URL:
http://ftp.fibranet.cat/smf-spf/smf-spf.spec
SRPM URL:
http://ftp.fibranet.cat/smf-spf/smf-spf-2.4.3-1.el8.src.rpm
Thank you very much.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component