https://bugzilla.redhat.com/show_bug.cgi?id=1427341
--- Comment #17 from VincentS <vincent(a)casperlefantom.net> ---
(In reply to Miro Hrončok from comment #16)
First, /usr/lib64/python2.7/site-packages/gamera/gendoc.py:
This is a bit more complicated.
Based on the rpmlint output you can say that:
* the file has a shebang that says "#!/usr/bin/env python" (note that using
/usr/bin/env in shebangs is forbidden in Fedora packages)
* the file does not have executable permissions
So you have to ask yourself the question: "Shall this file be treated as
executable or not?" The answer is usually "not" unless the file is in
PATH
(such as /usr/bin). So in this case instead of giving it permissions, remove
the shebang. This is nice approach, as it checks if the shebang is there and
if so, it removes it:
head -n 1 gamera/gendoc.py | grep '#!/usr/' && sed -i '1d'
gamera/gendoc.py
If the file should have been an executable (not this case), you would need
to change the shebang to "#!/usr/bin/python2" and add the executable
permission.
Second: README:
I'd suggest running "chmod -x README" in %prep instead, as it explicitly
says "remove the executable permission" rather than "set the permissions
to
exactly this and that".
Ok, all right.
Now I'll know for future through your really good explanations.
I fixed this according to your recommendations.
Here are new SPEC and SRPM:
Spec URL:
https://dl.casperlefantom.net/pub/review/python-gamera.spec
SRPM URL:
https://dl.casperlefantom.net/pub/review/python-gamera-3.4.3-2.fc25.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component