https://bugzilla.redhat.com/show_bug.cgi?id=1673956
--- Comment #2 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, this is an additional review to #1. Please read this for you reference.
Summary =======
1. Legibility 2. Source URL 3. Bundling multiple GitHub project's code 4. Directory Ownership
Details =======
1. Legibility -----------
Each package must consistently use macros. Here are guidelines::
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_...
2. Source URL
The "extraversion" macro value, which is "_11_g6a75e98", should be included in the SOURCE0 comment description. Here is the result of the part of the comment description::
$ cd openEMS-Project; git describe --tags | sed -e s,-,_, v0.0.35_13-g78e7642
I think the value should be same with the "extraversion" macro value, because the sources used to build the package must match the upstream source. See the SourceURL guidelines.
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
3. Bundling multiple GitHub project's code
The openEMS-Project contains multiple GitHub project's source code as GitHub submodules. Each submodule the parent module depends on should be a link to a module globally installed from a package, because I think the Fedora package guidelines are basically provided that one software, which I think is defined by its own license and version, should be one package.
4. Directory Ownership
The following directories should be removed after removing relevant packages::
/usr/share/octave/packages/csxcad-0.0.35/private /usr/share/octave/packages/openems-0.0.35/private
The following patch solved the problem above in my environment::
$ diff octave-openems.spec.orig octave-openems.spec 299a300
%dir %{octpkgdir}/private
306a308
%dir %{octpkgdir}/private
See http://ftp.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html for the %docdir directive.
Thanks in advance, Hirotaka Wakabayashi