https://bugzilla.redhat.com/show_bug.cgi?id=2022554
--- Comment #11 from Nils Philippsen nphilipp@redhat.com --- (In reply to Ben Beasley from comment #10)
The package is APPROVED; however, please see the Issues section below, and make sure you fix the ownership of the %{_pkgdocdir}-devel-doc directory immediately upon unretirement.
Thanks for the review!
Issues:
Nothing owns %{_pkgdocdir}-devel-doc. Please change:
%files devel-doc %doc %{_pkgdocdir}-devel-doc/html
to
%files devel-doc %doc %{_pkgdocdir}-devel-doc
or otherwise ensure the devel-doc subpackage owns this directory.
Oops. Will do!
- The hardlink invocation did not eliminate the duplicate file warnings from rpmlint, because the files in question had duplicate content but not duplicate mtimes, so nothing was hardlinked. I think that, for packaging purposes, hardlink is in the right here, and it is better to ignore the rpmlint warnings (and optionally remove the call to hardlink as useless)
than to add the “-t” option to hardlink.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps
Makes sense, will do.