Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=725243
Martin Gieseking <martin.gieseking(a)uos.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.gieseking(a)uos.de
--- Comment #1 from Martin Gieseking <martin.gieseking(a)uos.de> 2011-08-02 12:42:52
EDT ---
Hi Raphael,
here are some quick comments on your package:
- the license of the program is GPLv2+ because of the addition
"or (at your option) any later version" in the copyright notice.
- replace BR: python > 2.4 with BR: python2-devel
- The package doesn't seem to provide arch-dependent files. Thus add
BuildArch: noarch
- the .desktop file must be verified with desktop-file-validate
http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
- patch the .desktop file to not use absolute paths (Exec and Icon)
- see here how to install the locale files properly:
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
- Drop the asterisk from %{_datadir}/%{name}/* for proper directory ownership.
- replace %{_mandir}/man1/%{name}.1.gz with %{_mandir}/man1/%{name}.1*
- drop the empty %doc line in %files
- the documentation should be installed into
%{_defaultdocdir}/%{name}-%{version}. The easiest way to do that is to
remove the installed docs from the buildroot and add it with %doc:
* add rm -rf %{buildroot}%{_datadir}/doc/ to %install
* add %doc doc/ to %files
* remove %{_defaultdocdir}/%{name}/* from %files
This also adds the missing file "copyright"
Have a look at the packaging guidelines for further information:
http://fedoraproject.org/wiki/Packaging:Python
http://fedoraproject.org/wiki/PackagingGuidelines
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.