https://bugzilla.redhat.com/show_bug.cgi?id=2121585
--- Comment #5 from Renich Bon Ciric <renich(a)woralelandia.com> ---
You rock! i definitely owe you one. :D
Fixed most of the issues. Let me address a few, though:
Do all the tests need network access? IF not, it would be good to try
to run those that do not.
It seems that the tests deviate from the generally used: make test. Also,
they're more of a functionality test than unit or integration tests. It
requires pip and it spins up a janus-gateway server and uses python to test
it's functionality.
I'm in the process of getting this to work using mock. That said, I dunno if I
want to do that in koji's minions... It's OK for local development but not so
much for automated testing. My two cents on that...
Licenses used:
*No copyright* GNU General Public License, Version 3
----------------------------------------------------
janus-gateway-1.0.4/README.md
janus-gateway-1.0.4/bower.json
janus-gateway-1.0.4/npm/package.json
janus-gateway-1.0.4/package.json
BSD 3-Clause License
--------------------
janus-gateway-1.0.4/fuzzers/corpora/rtcp_fuzzer/2webrtc/LICENSE
MIT License
-----------
janus-gateway-1.0.4/html/janus.js
janus-gateway-1.0.4/src/plugins/duktape-deps/LICENSE.txt
The BSD-3-Clause license covers the fuzzers. They do not get packaged, AFAICT.
Do we include them and throw in the license anyway?
Also, the MIT license covers one of the plugin's deps. I dunno what to do in
this case. Maybe just include the license as well?
What do you think? I appreciate your hard work, btw. :D
New sources at:
Spec URL:
https://renich.fedorapeople.org/janus-gateway/janus-gateway.spec
SRPM URL:
https://renich.fedorapeople.org/janus-gateway/janus-gateway-1.0.4-3.fc36....
It was a bad idea to use pagure to publish these (the SRPM at least). Moved to
fedorapeople.org.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2121585