https://bugzilla.redhat.com/show_bug.cgi?id=2163518
--- Comment #8 from Ondrej Mosnáček <omosnacek(a)gmail.com> ---
(In reply to Troy Curtis from comment #7)
(In reply to Ondrej Mosnáček from comment #5)
> (In reply to Troy Curtis from comment #4)
> > - If I enable the tests, they all fail. Either due to errors
> > (AttributeError: 'NoneType' object has no attribute 'tags') or
failures
> > (AssertionError: 11 != 13).
>
> That seems to be due to missing commit d11e92b45907 ("tests: fix download of
> the Ogg file"). When I apply it as a patch (with b3df8561f38e as a context
> dependency) they pass for me with the current ffmpeg-free (used to require
> full ffmpeg from RPMFusion, but thanks to [1] it doesn't anymore). Would you
> like me to add those patches to the spec?
Yes, it only makes sense to include the conditional test block if enabling
it would result in a usable configuration. I suspect as a packager, having
the tests functional will be very useful, so I would definitely recommend
applying the patch. Since these tests can't be run on koji anyway due to the
network requirement, it might be equally valid to remove the test option
entirely.
It might be nice to try to nudge upstream to roll a new release since it
seems like there are a few fixes which have been merged since the last
release.
I did and the maintainer made a new release very quickly in response, so I
bumped the version to 1.0.7 and now the tests pass (tested with `fedpkg
mockbuild --enable-network --with tests`).
I also added manpage generation via argparse-manpage.
Spec URL:
https://gitlab.com/omos/fedora-package-review/-/raw/324bf0d9380d296edbfbc...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/omos/r128gain/srpm-bui...
Copr build:
https://copr.fedorainfracloud.org/coprs/omos/r128gain/build/5708631/
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2163518