Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701801
Sergio Pascual <sergio.pasra(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #7 from Sergio Pascual <sergio.pasra(a)gmail.com> 2011-12-03 11:19:51 EST
---
Rpmlint output:
ast.src:12: W: macro-in-comment %{srcver}
ast.src: W: invalid-url Source0: ast-6.0-1.tar.gz
ast-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/ast-6.0-1/loader.h
ast-devel.x86_64: W: spelling-error %description -l en_US prog -> prig, prof,
pro
ast-devel.x86_64: W: no-documentation
ast-devel.x86_64: W: no-manual-page-for-binary ast_link
Package and spec are named according the guidelines
License is GPLv2+ and LGPLv2+
Specfile legible
Source matches upstream, source follows the convention for Troublesome URLs
(see
http://fedoraproject.org/wiki/Packaging/SourceURL)
Package builds, No ExcludeArch needed
BuildRequires listed
ldconfig called properly
No bundled libraries (the files from wcslib have been modified by ast
developers, so I don't consider it to be the same library.)
Owns directories it creates
Macros are consistent
Large docs are in -doc subpackage
Headers and .so are in -devel subpackage
-devel requires base package
No .la files
BuildRoot is not needed
%clean is not needed
Package is APPROVED
By the way, you are not required to fix the incorrect FSF address. But if you
do, please fix also loader.h before uploading
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.