https://bugzilla.redhat.com/show_bug.cgi?id=2268124
--- Comment #19 from Ben Beasley <code(a)musicinmybrain.net> ---
(In reply to Ben Beasley from comment #17)
I exclude i686 from the beginning under
https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval, so I don’t
need fix-build-on-odd-archs.patch.
Sorry, this is incorrect. I *should* have your patch, or equivalently add
-Wno-error=type-limits via CXXFLAGS; my spec file doesn’t work anywhere but
x86_64.
/builddir/build/BUILD/loguru-4adaa185883e3c04da25913579c451d3c32cfac1/loguru.cpp:
In function ‘void loguru::escape(std::string&, const std::string&)’:
/builddir/build/BUILD/loguru-4adaa185883e3c04da25913579c451d3c32cfac1/loguru.cpp:571:36:
error: comparison is always true due to limited range of data type
[-Werror=type-limits]
571 | else if (0 <= c && c < 0x20) { // ASCI
control
character:
| ~~^~~~
/builddir/build/BUILD/loguru-4adaa185883e3c04da25913579c451d3c32cfac1/loguru.cpp:
In function ‘loguru::Text loguru::ec_to_text(char)’:
/builddir/build/BUILD/loguru-4adaa185883e3c04da25913579c451d3c32cfac1/loguru.cpp:1845:28:
error: comparison is always true due to limited range of data type
[-Werror=type-limits]
1845 | else if (0 <= c && c < 0x20) {
| ~~^~~~
(The underlying issue is that char may be signed or unsigned, and on platforms
where it defaults to signed, the comparison is useless/tautological. However,
it’s not harmful or incorrect.)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2268124
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...