https://bugzilla.redhat.com/show_bug.cgi?id=1552767
--- Comment #3 from Neal Gompa <ngompa13(a)gmail.com> ---
Spec review notes:
%if 0%{?mageia}
BuildRequires: appstream-util
%else
BuildRequires: libappstream-glib
%endif
This could be simplified to "BuildRequires: %{_bindir}/appstream-util"
"dnf install /usr/bin/appstream-util" works on both Fedora and Mageia, so I
would think this should work in your spec.
# Git commit slightly newer than 2.87
# Can be unbundled if bullet 2.88+ is available
Provides: bundled(bullet) = 2.87
If you know the Git commit, could you put that in the Provides versioning?
Something like the following:
Provides: bundled(bullet) = 2.87+git<commitdate>.<shorthash>
# Has some modifications for IPv6 support, upstream enet is
unresponsive
# Should not be unbundled.
Provides: bundled(enet) = 1.3.13
I checked into this, it seems like upstream seems to want a mailing list
discussion first[1]? I'm not entirely sure what this means, but it'd be nice if
IPv6 support was in upstream enet (there are three pull requests for it...)
[1]:
https://github.com/lsalzman/enet/issues/78
# Upstream commit from 2016, newer than 1.0.0.27 which is last tag
# Could be unbundled if packaged.
# Godot upstream will soon deprecate this "libsimplewebm" module.
Provides: bundled(libwebm)
As you're an upstream developer, I would suggest that libmatroska would be a
better alternative to libwebm (libmatroska can parse webm containers too, since
they are a subset of mkv). But if you're deprecating it...
# Has custom changes to support seeking in zip archives
# Should not be unbundled.
Provides: bundled(minizip) = 1.2.4
OK.
# Could be unbundled if packaged.
Provides: bundled(nanosvg)
If this[2] is the nanosvg in question, I can see why it's bundled instead of
packaged.
Could you indicate what commit is packaged in nanosvg? You can do something
like the following:
Provides: bundled(nanosvg) = 0-0.git<commitdate>.<shorthash>
[2]:
https://github.com/memononen/nanosvg
# Could be unbundled if packaged.
Provides: bundled(squish) = 1.15
Is there any reason it couldn't be packaged? It looks like libsquish is fairly
active and releases often enough.
# Can't be unbundled out-of-the-box as it uses experimental APIs
available
# only to static linking. They're not critical features though and could
# maybe be patched away to link against a shared zstd.
Provides:
bundled(zstd) = 1.3.3
Have you talked to upstream[3] about stabilizing the APIs used by Godot so that
it can use a dynamically linked libzstd?
[3]:
https://github.com/facebook/zstd
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component