https://bugzilla.redhat.com/show_bug.cgi?id=2290665
--- Comment #4 from Aurelien Bompard aurelien@bompard.org ---
The URL field could be https instead of http
Fixed, thanks.
I don't think you need the rm -rf $RPM_BUILDROOT
I've used the spectemplate that comes with rpmdevtools, it's apparently still there. I've removed it, it's been optional for ages.
The changelog entry is for 1.0.0-1, the version in the spec is 1.0.1-1
Good catch!
I'd recommend using %autorelease and %autochangelog, but I'm guessing this is heading for EPEL repositories and maybe those macros aren't available? Either way, not deal-breakers.
Yeah, it'll have to go to both Fedora and EPEL
I think that spelling is fine and clear. It definitely shouldn't be "integration's".
Thanks.
It does seem the package depends on a deprecated version of sqlalchemy (but presumably not deprecated in EPEL?).
It's actually compatible with SQLAlchemy 1.4 and 2.x, I test it in tox (but not in this package, it just runs pytest). It's 1.4 though, not 1.3, I'll fix it upstream for the next release.
Thanks for the review!