https://bugzilla.redhat.com/show_bug.cgi?id=1834731
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
--- Comment #6 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
-
Source0:
http://github.com/%{name}/%{name}/archive/v%{version}.tar.gz#/%{name}-%{v...
→
Source0:
http://github.com/%{name}/%{name}/archive/v%{version}/%{name}-%{version}....
- Why does the core subpackage obsoletes the main package? Also for a rename
the Obsolete part must be fixed, to the release above the last release of the
obsoleted package.
%package core
Summary: Peer to Peer Cryptographic Currency
Obsoletes: %{name} < %{version}-%{release}
Provides: %{name} = %{version}-%{release}
- GZipping the man pages is handled by rpm, do not do it yourself:
gzip %{buildroot}%{_mandir}/man1/$i.1
- This is only needed in EPEL7:
%post core
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun core
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi
%posttrans core
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
Please put it behind a condition.
- Do not package libtool archive. Static library are generally not packaged,
and, if really needed, must have their own static subpackage:
%{_libdir}/libbitcoinconsensus.a
%{_libdir}/libbitcoinconsensus.la
- In order to avoid unintentional soname bump, we recommend not globbing the
major SONAME version from shared library. Be more specific instead:
%{_libdir}/libbitcoinconsensus.so.*
- /var/lib/, {_localstatedir}/lib → use %{_sharedstatedir}
- /var/, %{_var} → use %{_localstatedir}
- /run → %{_rundir}
- I know nothing about SELinux, I need to find another reviewer for this
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component